Bugs for Sorcery are reported here

[bugzilla-daemon AT bugs.sourcemage.org]

http://bugs.sourcemage.org/show_bug.cgi?id=9846

           Summary: scm updates should fall back on previous checkout
           Product: Sorcery
           Version: 1.13.x
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Summon
        AssignedTo: sm-sorcery-bugs AT lists.ibiblio.org
        ReportedBy: acedit AT armory.com


scm updates should fall back on previous tarball

On Mon, Sep 26, 2005 at 04:57:32PM -0500, Jeremy Blosser (emrys) wrote:       
  
> On Sep 26, Andrew [afrayedknot AT thefrayedknot.armory.com] wrote:             
>   
> > Stable sorcery did not check the return code, it assumes cvs always 
> > works.  
> > Thats a bug. That and several other things were what prompted the major   
> >   
> > re-factoring of download code.                                            
> >   
> >                                                                           
> >   
> > Im open to suggestions on a better compromise behavior for failed scm     
> >   
> > checkouts.                                                                
> >   
>                                                                             
>   
> I guess the more complicated thing to do would look like:                   
>   
>                                                                             
>   
> - preexisting scm checkout spool tarball is available?                      
>   
>   - Y: attempt to update                                                    
>   
>     - update succeeded?                                                     
>   
>       - Y: create new spool tarball                                         
>   
>       - N: abandon any partial update, revert back to preexisting tarball   
>   
>   - N: attempt initial checkout                                             
>   
>     - checkout succeeded?                                                   
>   
>       - Y: create spool tarball                                             
>   
>       - N: die                                                              
>   
>                                                                             
>   
> The case where it fails the update and we revert back to an existing        
>   
> tarball probably would need to ask the user what to do next*.  The source   
>   
> hasn't changed at all but maybe they want/need to do a rebuild of what they 
>   
> have anyway.                                                                
>   
>                                                                             
>   
> (*It may do this now, I haven't seen a failed cvs update on test sorcery in 
>   
> practice yet.)      

Easiest thing to do is in download_src_args when download_src_sub fails, check
if guess_type == tree, if $SOURCE_CACHE/$target exists, and some user 
controlled
setting (via menu) is enabled, and "succeed" with the existing tarball.

-- 
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.