Skip to Content.
Sympa Menu

sm-sorcery-bugs - [SM-Sorcery-Bugs] [Bug 8732] Xpdf patch aborts with bad MD5 on patch

sm-sorcery-bugs AT lists.ibiblio.org

Subject: Bugs for Sorcery are reported here

List archive

Chronological Thread  
  • From: bugzilla-daemon AT bugs.sourcemage.org
  • To: sm-sorcery-bugs AT lists.ibiblio.org
  • Subject: [SM-Sorcery-Bugs] [Bug 8732] Xpdf patch aborts with bad MD5 on patch
  • Date: Tue, 26 Apr 2005 17:54:09 -0700 (PDT)

http://bugs.sourcemage.org/show_bug.cgi?id=8732





------- Additional Comments From acedit AT armory.com 2005-04-26 17:54 -------
This particular problem stems from the xpdf spell calling unpack with the full
path to the source file. The unpack routine automatically prepends
$SOURCE_CACHE, which in this case is already in the variable. So,
guess_filename
fails and returns an empty string, then in stable sorcery we run
uncompress $FILENAME $COMPRESSOR $MD5

problem with that is, the filename and compressor arent quoted which
evaluates to
uncompress $MD5
$MD5 is not a filename though. In stable unpacking claims to succeed, even
though it did *nothing*. In devel it gets an invalid md5sum, which is also
incorrect.

What should happen is before uncompressing we should validate that the file
exists and raise a complaint if not.

The xpdf file is rectifiable if they specify the filename without
$SOURCE_CACHE
prepended. However the larger issue is that we're not failing properly if
downloads fail.

The following changes must be made:
in 1.12:
real_unpack should raise an error if guess_filename fails or returns empty
real_unpack should quote its arguments

in 1.13
real_unpack should raise an error if guess_filename fails or returns empty
uncompress_unpack should also raise an error under the same conditions

--
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.




Archive powered by MHonArc 2.6.24.

Top of Page