Skip to Content.
Sympa Menu

sm-sorcery-bugs - [SM-Sorcery-Bugs] [Bug 8136] New: libstatus: query_spell_status & get_status uion

sm-sorcery-bugs AT lists.ibiblio.org

Subject: Bugs for Sorcery are reported here

List archive

Chronological Thread  
  • From: bugzilla-daemon AT bugs.sourcemage.org
  • To: sm-sorcery-bugs AT lists.ibiblio.org
  • Subject: [SM-Sorcery-Bugs] [Bug 8136] New: libstatus: query_spell_status & get_status uion
  • Date: Sat, 29 Jan 2005 12:27:39 -0800 (PST)

http://bugs.sourcemage.org/show_bug.cgi?id=8136

Summary: libstatus: query_spell_status & get_status uion
Product: Sorcery
Version: Untargetted future release
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: subroutines
AssignedTo: sm-sorcery-bugs AT lists.ibiblio.org
ReportedBy: vlmarek AT volny.cz


The two functions does (nearly) the same, get_status just ignores optional
$version parameter. Moreover query_spell_status always return 0, the only case
it returns 1 is when $SPELL_STATUS file is missing.

I propose:

* remove get_status, and replace it by query_spell_status (only affected will
be libdepends internally)

* Document when query_spell_status returns error (1); more sense gives me
returning 1 when spell is not found ( and function checks the return value,
only
get_status which I want to remove)

* Remove esc_str function from first parameter of query_spell_status, since
spell names can be only [a-zA-Z_] ( or something similar ). For version it has
to stay ( but esc_str itself does bad job on escaping strange characters
anyway ).

* Document that first input variable of query_spell_status can hold regexes (
find all spells beginning with X = query_spell_status ("X.*"), second is
escaped

--
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



  • [SM-Sorcery-Bugs] [Bug 8136] New: libstatus: query_spell_status & get_status uion, bugzilla-daemon, 01/29/2005

Archive powered by MHonArc 2.6.24.

Top of Page