Skip to Content.
Sympa Menu

sm-sorcery-bugs - [SM-Sorcery-Bugs] [Bug 7296] Libpatch

sm-sorcery-bugs AT lists.ibiblio.org

Subject: Bugs for Sorcery are reported here

List archive

Chronological Thread  
  • From: bugzilla-daemon AT metalab.unc.edu
  • To: sm-sorcery-bugs AT lists.ibiblio.org
  • Subject: [SM-Sorcery-Bugs] [Bug 7296] Libpatch
  • Date: Thu, 2 Sep 2004 10:53:02 -0400

http://bugs.sourcemage.org/show_bug.cgi?id=7296





------- Additional Comments From pmahon AT sourcemage.org 2004-09-02 10:53
-------
Looking good. There are several things you should change though.
- Use query instead of message ; query
- Use bashdoc comments for functions
- It's custom, not costum

Also double check how variables holding file names are being used. If a
variable
holding a file name which may have spaces is used, it should have quotes
around
it to prevent bash from passing it as multiple arguments.

In several places you have cd $something. Why? If a command is changing the
directory, you might want to use ( ) to isolate. Ex: pwd ; (cd /;pwd;); pwd
If you need to change directory for your script, consider using pushd and
popd.

That's all for now ;)

Good stuff though.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.




Archive powered by MHonArc 2.6.24.

Top of Page