Bugs for Sorcery are reported here

[bugzilla-daemon AT metalab.unc.edu]

http://bugs.sourcemage.org/show_bug.cgi?id=4246

seth AT tautology.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |seth AT tautology.org



------- Additional Comments From seth AT tautology.org  2003-09-04 06:01 -------
well, perhaps ensign, colonel, major, etc. are better terms?  j/k

I haven't run it yet, but I've noticed these from a glance at the code:

1) I love the to-section idea.  Nice.

2) the code used in cast to switch to root requires that while the script is
running non-root, it does nothing but switch to user root.  Your if then needs
to have all the rest of the code (except subroutines) in an else block or
immediately exit after it runs the 'su' command with the exit value of the 
full
root instance (more proper, since it would return an accurate return value (I
didn't check to see if it even returned any exit values outside of 0, so the
return value stuff might be moot).  All that code does is re-run the command
under root.  You don't want it exiting the root-instance and then running the
rest of the code _again_ in the original instance as a non-root user.  I hope
that explains it well.  (so just add "exit $?" after the "su ..." line and see
if that works ... perhaps cast should have this as well.)

3) the scribe reindex code is optimizable since you are inserting only one 
item
into the index, in theory, or removing one item.  Since I expect this to be 
not
such a bid deal (indexing is quite fast as it is and cast is a much longer
operation), I don't care so much, but I put this out in case anybody feels 
like
rewriting those sections to not reindex the whole thing.

Great work to both of you though.  Hope my comments help.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.