Skip to Content.
Sympa Menu

sm-grimoire - Re: [SM-Grimoire] j2sdk

sm-grimoire AT lists.ibiblio.org

Subject: Discussion of Spells and Grimoire items

List archive

Chronological Thread  
  • From: Casey Harkins <charkins AT upl.cs.wisc.edu>
  • To: Jose Bernardo Silva <josebernardo1 AT yahoo.com>
  • Cc: sm-grimoire AT lists.ibiblio.org
  • Subject: Re: [SM-Grimoire] j2sdk
  • Date: Tue, 21 Jan 2003 05:23:10 -0600 (CST)


I see a few problems with your spell, and haven't gotten around to fixing
them so I can test the build.

1) z-rejected PRE_BUILD stuff is missing: I'm guessing that you based this
off of your previous work, however, when it was added to the grimoire the
PRE_BUILD was modified to include the z-rejected message and query. Adding
this back in should be trivial. Can we get a rejected_prebuild function in
sorcery to simplify the PRE_BUILD in z-rejected spells?

2) I'm not sure which source you built from (1.4.0 or 1.4.1), but the MD5
doesn't match on my end for the main source file. I don't see it available
as a single file on Sun's site, so it would make more sense I think for
the spell to list both source files and handle the concatenation itself
(see my j2sdk spell on sm-spell-submit from last week). In addition to
concatenating the files, 'zip -F' needs to be run on the concatenated zip
to fix it. Perhaps this is where the MD5 got off.

3) The end of the BUILD does a cp and ln involving the directory
/opt/java/j2sdk-1.4.0-tt. If you are using the 1.4.1 source, this
directory should be /opt/java/j2sdk-1.4.1-tt. If you still have your older
j2sdk install around, then this wouldn't have failed so you might have not
noticed.

4) The licenses on all of the LFS patches are listed as GPL in your spell,
they should be SCSL.

5) Two little things: the jni.h workaround is no longer needed, it can be
removed from PRE_BUILD and POST_INSTALL. lesstif can also be removed from
DEPENDS. I'll let you know if I have problems building later with lesstif
installed.

I'm glad that we FINALLY have a real working java plugin again. The
earlier (lesstif) version worked fine on some pages, and would crash
mozilla on others. Hopefully we can get the spell whipped into shape in
the next day or two! If you have time, take a look at the spell I
submitted last week. It should only need the 'cd' fix you made (to get it
to build on the first attempt), the correct MD5's for the source, and for
the "echo [DEBUG]" statements to be removed. (I may have fixed #3 from
above after I submitted it to the list).

-casey

On Sun, 19 Jan 2003, Jose Bernardo Silva wrote:

> Casey, here is my version, now works at first try (I
> had a bad "cd"), and casts perfectly here. I didn't
> need the conflicts file, and I have lesstif
> 0.93.36 installed. Are you sure it is conflicting with
> your compile?
>
> If you can, take a look at this one, and we'll merge
> them and resubmit.
>
> I've added sm-spell-submit AT lists.ibiblio.org to the cc
> list, so that the spell goes there too.
>





Archive powered by MHonArc 2.6.24.

Top of Page