Skip to Content.
Sympa Menu

sm-grimoire - Re: [SM-Grimoire]Please look at my chrony spell

sm-grimoire AT lists.ibiblio.org

Subject: Discussion of Spells and Grimoire items

List archive

Chronological Thread  
  • From: Jason Flatt <jasonflatt AT wizard.com>
  • To: sm-grimoire AT lists.ibiblio.org
  • Subject: Re: [SM-Grimoire]Please look at my chrony spell
  • Date: Sat, 21 Dec 2002 09:41:57 +0000

As I had deleted all the test files, I had to re-do the spell testing. :^)

Also, I feel like most of this is so much nit-picking that I'm hesitant to
reply. Your spell is really fairly good, and I wouldn't want to discourage
you from attempting to submit any more by picking it to death on such minor
issues.


On Friday 20 December 2002 02:46 pm, Pierre Abbat wrote:
> On Thursday 19 December 2002 16:17, Jason Flatt wrote:
> > The spell looks fine except for three things:
> > 1) No MD5 -- really important
>
> How do I compute it? If a tarball is signed by the author, how do I specify
> the PGP key used to sign it?


I believe Seth has taken care of this.


> > 2) Include { and } around your variables i.e.:
> > ${SPELL}-${VERSION}.tar.gz -- probably the cure to your frustration
>
> What frustration?


In your DETAILS file you had commented out two SOURCE_URLs. I had originally
assumed that changing the variable name fixed the downloading, but this time
I just uncommented the SOURCE_URLs and got the file just fine from the first
one listed.

This was the frustration I was referring to. I had assumed that there was
some frustration based on your posts to the lists and the comments in the
DETAILS file. I was wrong, and please ignore me. :^)


> > 3) Cosmetic spacing -- it's minor and no big deal
>
> Can you show me?


According to the Grimoire Gurus Handbook
(http://wiki.sourcemage.org/index.php?page=GrimoireGurusHandbook):

2. You must include a HISTORY file to keep a log on the spell just include it
in the spell directory and use the following general format:

--begin--

2002-04-24[TWO-SPACES]Name[ONE-SPACE]<your AT mail.com>
[BLANK LINE HERE]
[TWO-TABS]Newer text describing the changes.
[BLANK LINE HERE]
2002-03-13[TWO-SPACES]Name<your AT mail.com.
[BLANK LINE HERE]
[TWO-TABS]This part of the text lists the changes that were made.
--end--

The format is simple and flexible for everyone.


And in the BUILD file, I would have changed the ./configure line to look more
like this:

./configure --prefix=/usr \
$OPTS &&

which doesn't look right with a proportional font, but has the options lined
up under each other, but the first one is on the same line as the ./configure
command itself.


> What is the proper way to handle the chrony.conf file? What section should
> this spell be in? Should the spell check what runlevel the computer is in
> before attempting to start chrony?
>
> phma


I don't know enough about the program to comment on the chrony.conf file, but
it looks fine by me. Does the program not generate it's own chrony.conf?

I would put it in the same section as the spell it conflicts with, ntp.

I still think that the runlevel stuff needs work. I hadn't even considered
checking the existing runlevel before starting the daemon, but I suppose that
should be done w/all spells that have something to potentially run at
startup.

I would also ask if they even want it started at all. I have spells I cast
merely for the utilities they provide (like bind), but I don't want them
automatically started. I realize that it doesn't make sense for some
programs to be installed w/o having their startup component running, but it
should still be an option. I would also ask which runlevels the user wanted
the program started in w/sane defaults.

I realize as I write this that I should be doing this w/cups as well, and I
am
not.


--
Jason Flatt
Section maintainer for printer
E-mail (remove the spaces): jasonflatt @ wizard . com
E-mail (remove the spaces): jflatt @ sourcemage . org
IRC: Oadae





Archive powered by MHonArc 2.6.24.

Top of Page