Skip to Content.
Sympa Menu

sm-grimoire - [SM-Grimoire]Re: [SM-Sorcery]Patch for config switch

sm-grimoire AT lists.ibiblio.org

Subject: Discussion of Spells and Grimoire items

List archive

Chronological Thread  
  • From: Ryan Abrams <rabrams AT sourcemage.org>
  • To: Nick Jennings <nkj AT namodn.com>
  • Cc: njennings AT sourcemage.org, sm-sorcery AT lists.ibiblio.org, sm-grimoire AT lists.ibiblio.org
  • Subject: [SM-Grimoire]Re: [SM-Sorcery]Patch for config switch
  • Date: Tue, 10 Sep 2002 18:56:29 -0500

Of course I'm not. I haven't got a way to read /every/ spell and determine how every spell works. I /am/ sure that CONFIGURE files shouldn't rely on variables in DETAILS, but our grimoire has a lot of spaghetti code, and I am sure 1 to 2 of them probably /do/ rely on it.

One of the things I had hoped to do was have the gurus test it. I guess now they will definately get to do that. ;)

I really did dig through the code, and I am confident that strange spell hacks aside, it will work, If it doesnt 0.8.1.0 can be released at any point.

-Ryan

On Tuesday, September 10, 2002, at 07:06 PM, Nick Jennings wrote:

Are you _sure_ that some CONFIGURE files do not need to have DETAILS
loaded?

I'm applying the patch for 0.8.1, if it breaks stuff we can switch
it back in the devel sorcery.

On Tue, Sep 10, 2002 at 05:56:57PM -0500, Ryan Abrams wrote:
Ok. There is a /very/ sparse patch available at
http://www.flipsidejones.net/swap.tgz. I have to admit I am not
familiar with patch (i know, i know) - so i just did 2 diffs using the
-u flag, which looks right.

Anyway, It does 2 things, and two things only.

1) It adds a SOURCE to $SPELL_CONFIG to the prepare_configure function,
so if it doesn't exist, it's created and the empty file sourced. If it
does, its simply sourced.

2) It swaps the order of run_details and run_configure in libdepends,
so that the build_depends function runs configure first.

I have just installed this on my system, and cast -r -c vim. I then
recast it to make sure it didnt ask for config options without the -c
option. Then i cast it again to make sure I could remove my newly
created options. In all cases, It worked. I didn't have time to cast
anything else to test it.

Feel free to test this out and give me your feedback. I think it works
well, and I think it will allow us to do lots of fun stuff in configure
that we couldn't do before, though it does not solve the branching
problem. Should be great for things like k18n though. :)

-Ryan

_______________________________________________
SM-Sorcery mailing list
SM-Sorcery AT lists.ibiblio.org
http://lists.ibiblio.org/mailman/listinfo/sm-sorcery






Archive powered by MHonArc 2.6.24.

Top of Page