SourceMage Grimoire Bug List

[bugzilla-daemon AT bugs.sourcemage.org]

http://bugs.sourcemage.org/show_bug.cgi?id=14130


jakakranjc AT email.si changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakakranjc AT email.si




------- Additional Comments From jakakranjc AT email.si  2007-11-26 13:52 -------
Here's my analysis. :)

BUILD:
Eek! BUILD is for building things, not installing (anymore). That should 
happen 
in INSTALL. Since you're playing in your local grimoire, add a toplevel 
API_VERSION file with BUILD_API=2 in it (like our official grimoires have).
HOME=/usr should be HOME="$INSTALL_ROOT/usr" so casting the spell somewhere 
else would work.

DETAILS:
Is there really no longer description available?

FUNCTIONS:
No, it is not needed.

HISTORY:
It is missing newlines between entries.

PRE_BUILD:
The installation stuff should be moved to INSTALL. The note from there 
applies 
here too.
texhash probably isn't needed here. The spell should have a FINAL and 
POST_REMOVE, which source TEX_FINAL and TEX_POST_REMOVE respectively (until 
someone overrides them in the latex/FUNCTIONS which would make things easier).
For one sed line less, you could use "soft quotes" and some escapes to 
subsitute the bash variables in the Makefile directly - no need to insert 
SPELL 
and co in it. Or like this:
sed  -i -e 's#= $(HOME)/public_html#= $(HOME)/share/doc/'$SPELL'#g' Makefile
The debug leftovers have no place in there too. As a final note, you don't 
need 
to escape the newlines after '&&'.

-- 
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.