SourceMage Grimoire Bug List

[bugzilla-daemon AT bugs.sourcemage.org]

http://bugs.sourcemage.org/show_bug.cgi?id=13596





------- Additional Comments From sobukus AT sourcemage.org  2007-03-07 02:57 
-------
That's not nice...
It didn't realize that we have that fix in qemu now; back when we discovered 
the build issues it has, I changed my private BUILD to

message "removing sse flags" &&
list_remove CFLAGS -msse -msse2 -msse3 &&
if [[ "$CFLAGS" =~ '-march=pentium[234-]\S*' ]]; then
  message reducing your march setting to pentium-mmx
  list_remove CFLAGS $BASH_REMATCH &&
  CFLAGS="$CFLAGS -march=pentium-mmx"
fi &&
message "flags now: $CFLAGS" &&
message "Target list:$QEMU_ARCHS"  &&

./configure --build=$BUILD             \
           --prefix=$INSTALL_ROOT/usr  \
       --sysconfdir=$INSTALL_ROOT/etc  \
    --localstatedir=$INSTALL_ROOT/var  \
      --enable-system --enable-user    \
                    $OPTS              &&

make


I believe that that would corretly replace -march=pentium4m 
with -march=pentium-mmx (I think I tested pentium3m).

This part of the current BUILD in grimoire

if grep -q softmmu <<< "$QEMU_ARCHS"; then
  CFLAGS=${CFLAGS/pentium4/pentium-mmx}  &&
  CFLAGS=${CFLAGS/pentium3/pentium-mmx}  &&
  CFLAGS=${CFLAGS/-march=athlon-xp/}  &&
  disable_pic
fi  &&

shows me that my variant at least should include the softmmu check, but apart 
from that there  are many cases this approach doesn't catch. For example I am 
using pentium-m, which is not catched by these but by my private version.
Perhaps we have to add
[[ "$CFLAGS" =~ '-march=athlon\S*' ]]
and replace every athlon* arch by athlon, but I didn't check on AMD cpus yet 
if this works. At least one should set it to pentium-mmx instead of dropping 
it all.

One reason for my approach not being adopted was the question if we allow 
this 
bash3 regex feature in spells... I think the end result was "yes"...


But apart from this all: It sucks that qemu doesn't compile with the usual 
arches and that needs to be fixed some time...

-- 
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.