SourceMage Grimoire Bug List

[bugzilla-daemon AT bugs.sourcemage.org]

http://bugs.sourcemage.org/show_bug.cgi?id=13359

           Summary: beryl spells' DETAILS have invalid operators
           Product: Codex
           Version: test grimoire
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: xorg-modular
        AssignedTo: sm-grimoire-bugs AT lists.ibiblio.org
        ReportedBy: iuso AT sourcemage.org


These don't look right. The = should of course be ==.

$ grep -r " = " .
./beryl-core/DETAILS:  if [ "$BERYL_CORE_TRUNK_AUTOUPDATE" = "y" ]; then
./beryl-plugins/DETAILS:  if [ "$BERYL_PLUGINS_TRUNK_AUTOUPDATE" = "y" ]; then
./beryl-settings/DETAILS:  if [ "$BERYL_SETTINGS_TRUNK_AUTOUPDATE" = "y" ]; 
then
./emerald-themes/DETAILS:  if [ "$EMERALD_THEMES_TRUNK_AUTOUPDATE" = "y" ]; 
then
./beryl-manager/DETAILS:  if [ "$BERYL_MANAGER_TRUNK_AUTOUPDATE" = "y" ]; then

A minor thing that also caught my eye was the use of [, [[ is preferred over 
[ 
because it's much faster (it's a bash builtin).

-- 
Configure bugmail: http://bugs.sourcemage.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.