Public SourceMage Discussion List

[Donald Johnson <ltdonny AT gmail.com>]

On 05/01/2010 06:55 PM, Ismael Luceno wrote:

Check it out, tell me what could be improved... I would like to make it
part of sorcery soon.
  

This came out of left field. I like it.

A few things:
-Backticks aren't an issue for me, but some people might like to see $(...) for executing statements.
-Comments pweeze? :3
-Should get_new_orphans really sort? That might be something to put into the executing statements outside of the functions. Nitpicky.
-I spy a few tabs
-There's a use of the `dialog` program explicitly instead of using the variable.

It's simple, and it works. Approve.