Skip to Content.
Sympa Menu

sm-discuss - Re: [SM-Discuss] banish

sm-discuss AT

Subject: Public SourceMage Discussion List

List archive

Chronological Thread  
  • From: Donald Johnson <ltdonny AT>
  • To: Ismael Luceno <ismael.luceno AT>
  • Cc: sm-discuss AT
  • Subject: Re: [SM-Discuss] banish
  • Date: Sun, 2 May 2010 22:13:11 -0500

On 05/01/2010 06:55 PM, Ismael Luceno wrote:
Check it out, tell me what could be improved... I would like to make it
part of sorcery soon.

This came out of left field. I like it.

A few things:
-Backticks aren't an issue for me, but some people might like to see $(...) for executing statements.
-Comments pweeze? :3
-Should get_new_orphans really sort? That might be something to put into the executing statements outside of the functions. Nitpicky.
-I spy a few tabs
-There's a use of the `dialog` program explicitly instead of using the variable.

It's simple, and it works. Approve.

Archive powered by MHonArc 2.6.24.

Top of Page