Public SourceMage Discussion List

[Arwed von Merkatz <v.merkatz AT gmx.net>]

On Fri, Jun 23, 2006 at 03:26:52PM +0200, Thomas Orgis wrote:
[...]
> I add one elif for alpha and - that's the part I wanna discuss - an else at 
> the end that makes the build fail if reached.
> I understand that the build must fail if GLIBC_ARCH was not set according 
> to a known architecture and think that it is a good thing to point that out 
> before it occurs.
> But there may be a reason for this else not being around in the first 
> place, so I ask now if my addition is really a good thing.
> 
> That's the diff:
> 
> diff --git a/libs/glibc/BUILD b/libs/glibc/BUILD
> index fc6c555..54b383c 100755
> --- a/libs/glibc/BUILD
> +++ b/libs/glibc/BUILD
> @@ -89,7 +89,18 @@ elif [[ ${SMGL_COMPAT_ARCHS[0]} == 32 &&
>    sedit  "s:CPPFLAGS += -DHAVE_INITFINI:CPPFLAGS += -DHAVE_INITFINI 
> -fno-pie -fno-PIE:"  csu/Makefile
>    export    CFLAGS="${CFLAGS/-fcall-used-g7/}"
>    export    CFLAGS="$CFLAGS  -fcall-used-g6"
> -fi  &&
> +elif [[ ${SMGL_COMPAT_ARCHS[1]} == alpha ]]; then
> +  # This is a first attempt to get alpha going, being paranoid about any 
> CFLAGS,
> +  # not without reason: -Os/-O breaks compile in strange ways:
> +  #  either an elf/ld.so that segfaults (build failing at sunrpc) or
> +  #  internal compiler error(s) in intl/
> +  # glibc knows itself what flags to choose
> +  export CFLAGS="" &&
> +  GLIBC_ARCH=alpha
> +else
> +  message "Glibc spell doesn't know your architecture!" &&
> +  false
> +fi &&
>  
>  # set the asm headers to point to the correct architecture
>  cd  $GLIBC_HEADERS_DIR/include  &&

That looks like a good idea, makes it obvious why the spell fails.

> PS: I would be happy if the archspecs for alpha in bug #12715 found their 
> way into smgl-archspecs some time...

smgl-archspecs were maintained in p4, not sure what the current status
about them is.

-- 
Arwed v. Merkatz                              Source Mage GNU/Linux developer
                                                    http://www.sourcemage.org