Public SourceMage Discussion List

[Juuso Alasuutari <iuso AT sourcemage.org>]

OK, I did it. But now I'm having second thoughts. With that conditional in 
place, doesn't the edit now _not_ fix bug #10764? Is it all in vain, and 
should I just revert it and simply put that source command in kdelibs?

Juuso

On Tuesday 18 April 2006 20:32, Juuso Alasuutari wrote:
> You're right, didn't think of this. I'll change that immediately.
>
> Juuso
>
> On Tuesday 18 April 2006 20:25, Eric Sandall wrote:
> > On Tue, 18 Apr 2006, Perforce Review Daemon wrote:
> > > Change 77909 by juuso_alasuutari@juuso_alasuutari-kamayuq on 2006/04/18
> > > 15:17:55
> > >
> > >   KDE_BUILD now sets $QTDIR if possible, fixes bug #10764.
> > >
> > > Affected files ...
> > >
> > > ... //sgl/grimoires/devel/kde-apps/KDE_BUILD#7 edit
> > > ... //sgl/grimoires/devel/kde-core/KDE_BUILD#6 edit
> > > ... //sgl/grimoires/devel/kde-look/KDE_BUILD#7 edit
> > >
> > > Differences ...
> > >
> > > ==== //sgl/grimoires/devel/kde-apps/KDE_BUILD#7 (xtext) ====
> > >
> > > @@ -6,4 +6,8 @@
> > >       --disable-dependency-tracking      \
> > >       $OPTS"                             &&
> > >
> > > +if [[ -f /etc/profile.d/qt.sh ]]; then
> > > +  . /etc/profile.d/qt.sh
> > > +fi                                       &&
> > > +
> > > default_build
> >
> > <snip>
> >
> > These should probably check if QTDIR is set rather than override what
> > the user may want used by manually setting their QTDIR for a specific
> > cast.
> >
> > e.g.
> > if  [ -z  $QTDIR ]; then
> >    . /etc/profile.d/qt.sh
> > fi
> >
> > -sandalle
>
> _______________________________________________
> SM-Discuss mailing list
> SM-Discuss AT lists.ibiblio.org
> http://lists.ibiblio.org/mailman/listinfo/sm-discuss