Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Ismael Luceno (8af70d6ca8527e55d84582739290995e3419ac2b)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Remko van der Vossen <wich AT sourcemage.org>
  • To: Ismael Luceno <ismael AT iodev.co.uk>
  • Cc: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Ismael Luceno (8af70d6ca8527e55d84582739290995e3419ac2b)
  • Date: Sat, 18 May 2019 14:48:55 +0200

Hi Ismael,

On Sat, May 18, 2019 at 02:40:24PM +0200, Ismael Luceno wrote:
> On 18/May/2019 09:04, Remko van der Vossen wrote:
> > Hi Ismael,
> >
> > On Sat, May 18, 2019 at 01:48:15AM +0000, Ismael Luceno wrote:
> > > GIT changes to master grimoire by Ismael Luceno <ismael AT sourcemage.org>:
> > > popt: Fix build against musl
> > > lzop: Fix build against musl
> > >
> > > diff --git a/archive/lzop/PRE_BUILD b/archive/lzop/PRE_BUILD
> > > +sedit 's!maybe_os in$!& linux-musl*|\\!' autoconf/config.sub &&
> > > diff --git a/libs/popt/PRE_BUILD b/libs/popt/PRE_BUILD
> > > +sedit 's!maybe_os in$!& linux-musl*|\\!' config.sub &&
> >
> > Are you also submitting patches upstream? While I applaud the effort of
> > making Source Mage musl compatible I don't think we want to grow the
> > amount of patches and sedits we have in the grimoires, but rather work
> > towards reducing them.
>
> It's not a patch for upstream projects; config.sub is generated, and
> shouldn't be part of the projects, it depends on the version of autoconf
> they used.

Same thing then, we should submit issues to them to update their release
process.

Regards, Remko




Archive powered by MHonArc 2.6.24.

Top of Page