sm-commit AT lists.ibiblio.org
Subject: Source Mage code commit list
List archive
Re: [SM-Commit] GIT changes to master grimoire by Eric Sandall (bf49bede0cd43fa32fb7d204709e849df63fd510)
- From: Remko van der Vossen <wich AT yuugen.jp>
- To: sm-commit AT lists.ibiblio.org
- Subject: Re: [SM-Commit] GIT changes to master grimoire by Eric Sandall (bf49bede0cd43fa32fb7d204709e849df63fd510)
- Date: Thu, 14 Apr 2016 13:17:10 +0200
On Sat, Apr 09, 2016 at 05:51:21PM +0000, Eric Sandall wrote:
> commit bf49bede0cd43fa32fb7d204709e849df63fd510
> Author: Eric Sandall <sandalle AT sourcemage.org>
> Commit: Eric Sandall <sandalle AT sourcemage.org>
>
> init.d: Allow setting RUN_SIZE
>
> default is 50%, so set that to keep consistency
> See https://lists.debian.org/debian-devel/2011/04/msg00615.html
> 50% is too large for many systems these days, so make this
> configurable as I only use 1% of 1% of my RAM on /run for a server.
Is this really a problem? As far as I know this size is a maximum. Upon
creation of the ramdisk, no (or very little) real memory is claimed.
Additional memory is only claimed when needed and actually used.
> diff --git a/smgl/init.d/HISTORY b/smgl/init.d/HISTORY
> + * init.d/devices.conf: Allow setting RUN_SIZE
> + default is 50%, so set that to keep consistency
> diff --git a/smgl/init.d/init.d/devices.conf
> b/smgl/init.d/init.d/devices.conf
> +# Defaults to 10% core memory; the size required varies widely
Which is it? 10% or 50%?
> diff --git a/smgl/init.d/init.d/devices b/smgl/init.d/init.d/devices
> - mount -n -t tmpfs tmpfs /run
> + mount -n -o size=${RUN_SIZE:-50%} -t tmpfs tmpfs /run
> diff --git a/smgl/init.d/init.d/devices.conf
> b/smgl/init.d/init.d/devices.conf
> +RUN_SIZE=50%
I don't like that we create our own shadow copies of the tmpfs default.
This would mean we do not follow upstream anymore when the default
within tmpfs changes. In my view the RUN_SIZE variable should not be
assigned and the devices script should not supply the size option when
no size has been configured in devices.conf.
Regards, Remko
-
[SM-Commit] GIT changes to master grimoire by Eric Sandall (bf49bede0cd43fa32fb7d204709e849df63fd510),
Eric Sandall, 04/09/2016
- Re: [SM-Commit] GIT changes to master grimoire by Eric Sandall (bf49bede0cd43fa32fb7d204709e849df63fd510), Remko van der Vossen, 04/14/2016
Archive powered by MHonArc 2.6.24.