Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] breakage in qt4_build and possibly in qt5_build and cmake_build

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Ismael Luceno <ismael.luceno AT gmail.com>
  • To: Florian Franzmann <siflfran AT hawo.net>
  • Cc: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] breakage in qt4_build and possibly in qt5_build and cmake_build
  • Date: Sun, 28 Jun 2015 04:51:08 -0300

On Sat, 27 Jun 2015 21:32:20 +0200
Florian Franzmann <siflfran AT hawo.net> wrote:
> Hi,
>
> cmake_build, qt4_build, qt5_build cd into $SOURCE_DIRECTORY as first
> step. In my opinion this is a very bad idea as it breaks all spells
> where the CMakeLists.txt or .pro file is not in $SOURCE_DIRECTORY. I
> think the part of sorcery that calls BUILD should change into
> $SOURCE_DIRECTORY (which it actually does in run_build in api2). The
> behaviour of qt4_build got changed in e6a41b02, which for example
> breaks the kdiff3 spell. I think this change should be reverted.
>
> Opinions?
>

+1.




Archive powered by MHonArc 2.6.24.

Top of Page