Source Mage code commit list

[Thomas Orgis <thomas-forum AT orgis.org>]

Am Wed, 1 Oct 2014 10:29:37 +0200
schrieb Remko van der Vossen <wich AT yuugen.jp>: 

> On Tue, Sep 30, 2014 at 05:51:29PM -0500, Ismael Luceno wrote:
> > -                  '--enable-startup-notification' \
> > -                  '--disable-startup-notification' \
> > +                  --{en,dis}able-startup-notification \
> 
> 
> Do we really need to start doing this?? I don't think it makes for a
> more readable spell.

Hm, I can understand the idea to shorten this, but also tend to think
that there is some value in having the verbatim option string there, to
reduce any ambiguity. When it's about being lazy about enable/disable or
with/without, extending optional_depends with an --enable or --with
switch to automaticall prepend --enable / --disable / --with /
--without would be my preferred method. But still, this doesn't help
readability and for sure not grep'ability. The main argument would be that

        optional_depends --enable 'pulseaudio' 'pulseaudio'

(or even just omitting the last 'pulseaudio' as shortcut to re-using
the dependency name) avoids typos between the enable/disable
counterparts.

> Also, I alphabetized the lists of depends in some larger DEPENDS files

... except where one dependency depends on another dependency being
selected or not ...


Alrighty then,

Thomas

Attachment: signature.asc
Description: PGP signature