Source Mage code commit list

[Florian Franzmann <siflfran AT hawo-net.de>]

On Do 2012-12-27 09:48:28 +0400, Vlad Glagolev wrote:
> What are you trying to do here?
> 
> First, 
> 
> > +     PATCH_LEVEL=1
> 
> there's no "PATCH_LEVEL", only "PATCHLEVEL".
will fix that.
> 
> second, why all the deps (included in  basesystem) are added?
I wasn't aware that we don't mention deps again that are already in
basesystem. How are triggers and up-triggers supposed to work reliably
if we don't? Should I remove dependencies that are already mentioned
in basesystem?
> 
> how did you generate these dependency lists? via checking configure.ac
> of every distribution? via doing ldd/readelf? If the last, it's not
> correct, since it could be nested linking information.
I got the information via objdump -p, which only shows libraries that are
actually used directly.
> 
> third, are you sure FAM is required for glib2? Since which release?
My mistake, FAM is already there as an optional dependency, I
overlooked that. Fixed in bdee10f6e3f53881a7e266e77a22ab63c4cd5197.

> 
> fourth, gnutls and openssl are different TLS implementations, are you
> sure this sequence:
> 
> > +if is_depends_enabled $SPELL gnutls; then
> > +  depends openssl
> > +fi &&
> 
> is correct?
No, that should be unconditional. Fixed in 
1613c2f1881a481ac9f5060d1ebf15538539a40e.

Thanks for the review.

regards
Florian
> 
> -- 
> Dont wait to die to find paradise...
> --
> Cheerz,
> Vlad "Stealth" Glagolev



> _______________________________________________
> SM-Commit mailing list
> SM-Commit AT lists.ibiblio.org
> http://lists.ibiblio.org/mailman/listinfo/sm-commit


--