Source Mage code commit list

[flux <flux AT sourcemage.org>]

Jaka Kranjc (scm AT sourcemage.org) wrote [12.08.28 00:57]:
<snip>
> diff --git a/var/lib/sorcery/modules/dl_handlers/dl_svn 
> b/var/lib/sorcery/modules/dl_handlers/dl_svn
> index 4f6471c..818bf0e 100755
> --- a/var/lib/sorcery/modules/dl_handlers/dl_svn
> +++ b/var/lib/sorcery/modules/dl_handlers/dl_svn
> @@ -50,6 +50,14 @@ function dl_svn_get () {
>        svn_args="$svn_args --trust-server-cert"
>      fi
>  
> +    local svn_format=$(head -1 $target/.svn/entries)
> +    message "${MESSAGE_COLOR}Subversion working copy format: 
> $svn_format${DEFAULT_COLOR}"
> +    if (( ${svn_format:-100} <= 10 )); then
> +      message "${MESSAGE_COLOR}Running svn upgrade...${DEFAULT_COLOR}"
> +      echo svn upgrade $svn_args $target
> +      svn upgrade $svn_args $target
> +    fi
> +
>      if test -d $target; then
>        message "${MESSAGE_COLOR}Running svn update...${DEFAULT_COLOR}"
>        echo svn update $svn_args -r $SVN_TAG $target
</snip>

I do believe $target here is (at least potentially) an arbitrary
path-containing variable (beyond strictly the svn hierarchy, if it
contains an absolute path), and therefore needs to be quoted. We
probably won't deal with $target containing spaces and whatnot, but I
think it's better to stay on the safe side and quote it anyway.

I'm not sure what types of characters svn allows for tag/revision
specifications, so those variables might need to be quoted as well to
prevent the shell from interpreting "funky" characters.

-- 
Justin "flux_control" Boffemmyer
Cauldron wizard and general mage
Source Mage GNU/Linux
http://www.sourcemage.org

Attachment: pgpJwiXYC4gWm.pgp
Description: PGP signature