Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Sukneet Basuta (6ce0e03ddb5a844fb50fbf7dd1b07c90016ce325)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Sukneet Basuta <sukneet AT gmail.com>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Sukneet Basuta (6ce0e03ddb5a844fb50fbf7dd1b07c90016ce325)
  • Date: Thu, 7 Jun 2012 11:59:57 -0400

On Thu, Jun 7, 2012 at 2:38 AM, flux <flux AT sourcemage.org> wrote:
> With the version 2 checks, it could *technically* pass for a 1.7 kernel
> as well, which of course would be erroneous. Now, I doubt very much that
> there is anyone running a SMGL system on anything lower than 2.4, but if
> we're going to make a check robus, how robust should we make it? This
> may not be an issue now, but if 4.0 suddenly comes out and is radically
> different from 2.x and 3.x, ideally our checks should be tightened more.
>
> Something like:
> if (( VER1 == 3 )) ||
>   (( VER1 == 2 )) &&
>     [[ (( VER2 > 6 )) || (( VER2 == 6 && VER3 > 14 )) ]] ||
>   spell_ok udev
>
> The VER1 == 3 check can be changed to VER1 > 2 later if later versions
> are verfied to work the same as 2 and 3. Or we could leave it at VER1 >
> 2 for now and change it if needed later. Just my 2 cents.

The issue with not including kernels >= 4.0 is that if the check is
false, it depends on udev-old. I imagine the current version of udev
will be more compatible with the latest kernel than a much older
version of udev. Even if it is incompatible, we'll have to do
something different anyway. I'm sure things will change in the
somewhat near future now that udev has merged into systemd in either
case.

Making the check for 2.x kernels more robust as you stated is probably
a good idea however.




Archive powered by MHonArc 2.6.24.

Top of Page