Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to devel-xorg-modular grimoire by Vlad Glagolev (ea0179834438cca6dee75bda193341c7e7a3c0c7)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Sukneet Basuta <sukneet AT gmail.com>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to devel-xorg-modular grimoire by Vlad Glagolev (ea0179834438cca6dee75bda193341c7e7a3c0c7)
  • Date: Wed, 23 May 2012 01:31:45 -0400

On Tue, May 22, 2012 at 5:55 PM, Vlad Glagolev <stealth AT sourcemage.org> wrote:
> I'm better thinking about reverting everything about this. Then --
> merging with branches like devel-xorg-modular as usually.
>
> tzdata integration _must_ be done in a branch first, then -- hardly
> tested, then -- ported in test and receive successful feedback.
>
> Sukneet, it'd be much better to do this way. Otherwise we just get a lot
> of broken installs and forgotten patches.

tzdata literally just installs timezone rules. Other than glibc (which
just needs to be patched to not install the rules), no other spell
should require a patch.

Other than my inability to properly write a spell, the only real issue
was that files that should be hard links under /usr/share/zoneinfo
were actual files. That should only happen in rare cases (according to
my testing), but I was aware of it before I pushed the spell.
Originally, I decided to not address it since it should not be common,
you would have the same issue with glibc if this was case and did not
see any bug reports about the issue (though I did admittedly see
http://pastebin.com/fxubrXKH . I have no idea if that is related
however), and I couldn't find a proper solution without wiping out
entire directories.

To keep everyone happy, I looked into it more and figured out what the
issue was (thanks in part to flux's talk about links :), so I
determined a proper solution.

With my last change, tzdata casts fine on every one of my systems and
test chroots. I think it belongs in test, but if you still feel
differently, let me know and I'll open up a branch.




Archive powered by MHonArc 2.6.24.

Top of Page