Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Arjan Bouter (799113ffd65dbd5d6c41bc47925d9db3e101ffda)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Sukneet Basuta <sukneet AT gmail.com>
  • To: Arjan Bouter <abouter AT sourcemage.org>
  • Cc: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Arjan Bouter (799113ffd65dbd5d6c41bc47925d9db3e101ffda)
  • Date: Sun, 20 May 2012 23:13:58 -0400

On Sun, May 20, 2012 at 10:48 PM, Sukneet Basuta <sukneet AT gmail.com> wrote:
> On Sun, May 20, 2012 at 7:42 AM, Arjan Bouter <scm AT sourcemage.org> wrote:
>> GIT changes to master grimoire by Arjan Bouter <abouter AT sourcemage.org>:
>>
>>  libs/tzdata/HISTORY |    4 ++++
>>  libs/tzdata/INSTALL |    4 +++-
>>  2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> New commits:
>> commit 799113ffd65dbd5d6c41bc47925d9db3e101ffda
>> Author: Arjan Bouter <abouter AT sourcemage.org>
>> Commit: Arjan Bouter <abouter AT sourcemage.org>
>>
>>    tzdata: use ln instead of zic so the spell works if /etc and /usr are on
>>    different partitions. Note that the SA still has to clean
>>    /usr/share/zoneinfo or the spell will fail.
>>
>> diff --git a/libs/tzdata/HISTORY b/libs/tzdata/HISTORY
>> index 049d838..31c6cfb 100644
>> --- a/libs/tzdata/HISTORY
>> +++ b/libs/tzdata/HISTORY
>> @@ -1,3 +1,7 @@
>> +2012-05-19 Arjan Bouter <abouter AT sourcemage.org>
>> +       * INSTALL: use ln instead of zic -l to avoid failure if /etc and
>> /usr are on
>> +         different partitions
>> +
>>  2012-05-17 Sukneet Basuta <sukneet AT sourcemage.org>
>>        * BUILD, CONFIGURE, DETAILS, INSTALL, PRE_BUILD, TRIGGERS: spell
>> created
>>        * timezones: timezone list
>> diff --git a/libs/tzdata/INSTALL b/libs/tzdata/INSTALL
>> index 420f8e8..db96231 100755
>> --- a/libs/tzdata/INSTALL
>> +++ b/libs/tzdata/INSTALL
>> @@ -13,7 +13,9 @@ echo "Local TIme Zone: " $LOCAL_TIMEZONE &&
>>  zic -y ./yearistype -d ${INSTALL_ROOT}/usr/share/zoneinfo ${TIMEZONES[@]}
>>                      &&
>>  zic -y ./yearistype -d ${INSTALL_ROOT}/usr/share/zoneinfo/posix
>> ${TIMEZONES[@]}                &&
>>  zic -y ./yearistype -d ${INSTALL_ROOT}/usr/share/zoneinfo/right -L
>> leapseconds ${TIMEZONES[@]} &&
>> -zic -y ./yearistype -d ${INSTALL_ROOT}/usr/share/zoneinfo -l
>> "$LOCAL_TIMEZONE"                 &&
>> +# zic -l breaks if /etc and /usr are on different partitions
>> +#zic -y ./yearistype -d ${INSTALL_ROOT}/usr/share/zoneinfo -l
>> "$LOCAL_TIMEZONE"                &&
>> +ln -sf ${INSTALL_ROOT}/usr/share/zoneinfo/$LOCAL_TIMEZONE
>> ${INSTALL_ROOT}/etc/localtime        &&
>>  #If you want POSIX compatibility, use "America/New_York".
>>  zic -y ./yearistype -d ${INSTALL_ROOT}/usr/share/zoneinfo -p
>> America/New_York                  &&
>>
>> _______________________________________________
>> SM-Commit mailing list
>> SM-Commit AT lists.ibiblio.org
>> http://lists.ibiblio.org/mailman/listinfo/sm-commit
>
>
> Are you sure that is the case? I actually looked into this before I
> did it and I read the opposite. If /usr and /etc are on different
> partitions and /usr fails to mount, /etc/localtime will fail, but not
> if zic installs it. When zic installs it, it makes a copy to
> /etc/localtime rather than a link, so I don't see how or why it should
> fail. Based on what I read zic is more robust than straight linking. I
> don't have a separate /usr partition though so I couldn't do much
> testing.

Actually, I just looked at the code for zic and it actually tries to
create a hard link first, then if that fails it creates a symlink. So
I guess either way is pretty much equivalent. Using install or cp
maybe a better solution though. I'll leave it up to you to decide.




Archive powered by MHonArc 2.6.24.

Top of Page