Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to devel-gis grimoire by Jaka Kranjc (18da230db6dc09e448eaa57788c30452cb067b3f)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Jaka Kranjc <smgl AT lynxlynx.info>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to devel-gis grimoire by Jaka Kranjc (18da230db6dc09e448eaa57788c30452cb067b3f)
  • Date: Sat, 08 Oct 2011 12:42:47 +0200

On Saturday 08 of October 2011 08:52:05 flux wrote:
> Jaka Kranjc (scm AT sourcemage.org) wrote [11.10.08 05:35]:
> <snip>
>
> > diff --git a/science/gdal-grass/DEPENDS b/science/gdal-grass/DEPENDS
> > index 16019df..5fd2559 100755
> > --- a/science/gdal-grass/DEPENDS
> > +++ b/science/gdal-grass/DEPENDS
> > @@ -1,3 +1,4 @@
> > -depends grass &&
> > +local gv=$(installed_version grass || (codex_set_current_spell_by_name
> > grass; echo $VERSION ) ) && +depends grass
> > --with-grass="$INSTALL_ROOT/usr/grass-$gv" &&
> >
> > depends proj4 &&
> > depends gdal
>
> </snip>
>
> Was the "(codex_set_current_spell_by_name; echo $VERSION)" intentional?
> It seems that if there is some error with
> codex_set_current_spell_by_name that what gets echoed will be the value
> of VERSION inherited by the parent shell, which in this case would be
> the version of gdal-grass. Also, I'm wondering why we don't just have a
> function for this in sorcery (i.e., codex_version grass, similar to
> installed_version).
It's not obvious, but it can't fail in a problematic way.

As for the api, there apparently is not enough need for that.
--
To err is humor




Archive powered by MHonArc 2.6.24.

Top of Page