Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master games grimoire by Ismael Luceno (0c4896c0f879b53751326d30f74e30ed8719c24e)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Eric Sandall <eric AT sandall.us>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master games grimoire by Ismael Luceno (0c4896c0f879b53751326d30f74e30ed8719c24e)
  • Date: Fri, 4 Mar 2011 16:26:55 -0800


On Dec 15, 2010, at 9:22 AM, Ismael Luceno wrote:

El Wed, 15 Dec 2010 07:15:21 +0100 (CET)
Andraž 'ruskie' Levstik <ruskie AT codemages.net> escribió:
:2010-12-14T15:35:Ismael Luceno:

games-strategy-tbs/wesnoth/desktop/wesnoth.desktop |    7 +++++--

New commits:
commit 0c4896c0f879b53751326d30f74e30ed8719c24e
Author: Ismael Luceno <ismael AT sourcemage.org>
Commit: Ismael Luceno <ismael AT sourcemage.org>

   wesnoth.desktop: use full path to the binary

@@ -34,6 +37,6 @@ Comment[sk]=Ťahová strategická hra z prostredia
fantasy Icon=wesnoth-icon.png
Terminal=false
FilePattern=wesnoth
-TryExec=wesnoth
-Exec=wesnoth
+TryExec=/usr/games/wesnoth
+Exec=/usr/games/wesnoth
Categories=Application;Game;

WHY? This will break the moment someone installs it somewhere else.
All that's needed for the other one to work is to add /usr/games to
the users PATH.


For consistency; other games do that way...

How could it be installed somewhere else *with this desktop file*??

You could autogenerate the .desktop files using $TRACK_ROOT, or just depend on $PATH being setup correctly for users that should be allowed to run the programs, as it was prior.

Just because others do it, doesn't mean it is the correct way. ;)

-sandalle

Eric Sandall                      Source Mage GNU/Linux Developer
http://eric.sandall.us/           http://counter.li.org/  #196285


  • Re: [SM-Commit] GIT changes to master games grimoire by Ismael Luceno (0c4896c0f879b53751326d30f74e30ed8719c24e), Eric Sandall, 03/04/2011

Archive powered by MHonArc 2.6.24.

Top of Page