Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by David Haley (907b1784aa641cd4e59592511d62e9fe91ed4b8a)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: flux <flux AT sourcemage.org>
  • To: "sm-commit AT lists.ibiblio.org" <sm-commit AT lists.ibiblio.org>
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by David Haley (907b1784aa641cd4e59592511d62e9fe91ed4b8a)
  • Date: Tue, 24 Aug 2010 19:32:15 +0900

Ladislav Hagara (ladislav.hagara AT unob.cz) wrote [10.08.24 18:36]:
> Hi,
>
> > New commits:
> > commit c26fbbbf888b9ff143c9ccb7bc215a50b240b626
> > Author: David Haley <khoralin AT gmail.com>
> > Commit: David Haley <khoralin AT gmail.com>
> >
> > Have added ability to cast stable or development source; added
> > PREPARE and updated DETAILS accordingly. 'gnucash2' listed in CONFLICTS
> > is not a valid spell at this time and
> > has been removed. gnucash-pubkey.key was not used by the spell and
> > was also removed.
>
>
> it is a good idea to start commit description with name of spell. It is
> fine to see name of spell in git log for example.
>
> gnucash - Have added ability ...

On the topic of commit descriptions, it would be best if people could
also try to adhere to the git recommendations for commit messages[1][2]
as well. The most important points here are wrapping text at 72 cols,
but having the "subject line" end after 50 chars. The reasons for these
rules are outlined in the git suggestions, which is that it is much more
readable in emails and that different git tools may expect the text to
have these lengths (only for formatting, so it looks ugly and is hard to
visually parse, but the tools will still *function* if you don't adhere
to these suggestions).

<example>
gnucash: added subdependency on foo with bar

Added a missing dependency foo with a subdependency on bar. This is
necessary for blaz support in gnucash.
</example>

[1]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
[2]:
http://www.kernel.org/pub/software/scm/git/docs/user-manual.html#creating-good-commit-messages

--
Justin "flux_control" Boffemmyer
Cauldron wizard and general mage
Source Mage GNU/Linux
http://www.sourcemage.org

Attachment: pgpv9A3oie4f6.pgp
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page