Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master sorcery by Jaka Kranjc (a3e5e92d7f4d8536f0645e5fa03b2d969721237d)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: flux <flux AT sourcemage.org>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master sorcery by Jaka Kranjc (a3e5e92d7f4d8536f0645e5fa03b2d969721237d)
  • Date: Mon, 5 Jul 2010 19:12:18 +0900

Jaka Kranjc (smgl AT lynxlynx.info) wrote [10.07.05 16:32]:
> > > - if test -f "$md5_log" && grep -qX "$my_md5" "$md5_log"; then
> > > + if test -f "$md5_log" && grep -qx "$my_md5" "$md5_log"; then
> > > false
> > > else
> > > true
> >
> > Be careful about this, as -X seems to be a newer grep flag, so I think
> > this will break for anyone who hasn't updated in a while. I just tested
> > this with grep 2.5.4 and it didn't work as intended.
> -X has been in grep at least since 2005, when a comment was added to the
> source that it is purposefully undocumented. The function of this option
> hasn't changed since then (matcher mode selection), but now there's a bit
> more error checking. Anyway, the purpose of this commit was to remove the
> X,
> not add it and 2.5 (and 2.4 and possibly even older) do support -x.
> So what did you try that made you think this doesn't work?

My dyslexia, apparently. ;)

I somehow switched which line was + and which - in my brain when I was
reading the change, so I erroneously thought the -x was being changed to
-X. Sorry about that.

--
Justin "flux_control" Boffemmyer
Cauldron wizard and general mage
Source Mage GNU/Linux
http://www.sourcemage.org

Attachment: pgpoARa2GpLkK.pgp
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page