Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Sukneet Basuta (6648586405b77f8b8573f3a23d14c93eae2552e7)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Florian Franzmann <siflfran AT hawo.stw.uni-erlangen.de>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Sukneet Basuta (6648586405b77f8b8573f3a23d14c93eae2552e7)
  • Date: Sat, 13 Mar 2010 10:10:09 +0100

On Sat, 13 Mar 2010 02:04:45 -0600
Sukneet Basuta <scm AT sourcemage.org> wrote:

> GIT changes to master grimoire by Sukneet Basuta <sukneet AT sourcemage.org>:
>
> ChangeLog | 10 ++++++++++
> 1 files changed, 10 insertions(+)
>
> New commits:
> commit 6648586405b77f8b8573f3a23d14c93eae2552e7
> Author: Sukneet Basuta <sukneet AT sourcemage.org>
> Commit: Sukneet Basuta <sukneet AT sourcemage.org>
>
> Changlog: added all the spells that I've created
> Did not know I was supposed to add all new spells to the changelog so
> I'm adding all the spells I've created now
I think the correct way of doing this would have been to revert your
commits and re-commit them including their Changlog entries, with a
distinct commit for each change.
>
> diff --git a/ChangeLog b/ChangeLog
> index 0cbdc01..5acd00a 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,13 @@
> +2010-03-13 Sukneet Saini <sukneet AT sourcemage.org>
> + * ftp/axel: new spell, a light download accelerater
> + * wm-addons/tabbed: new spell, a generic tabbed frontend
> + * ftp/eatmonkey: new spell, a download manager that works with aria2
> + * shell-term-fm/tty-clock: new spell, a ncurses digital clock for the
> console
> + * audio-players/deadbeef: new spell, an audio player with X11 and
> console support
> + * xfce/thunar-1.1: new spell, forked from thunar spell, latest
> version of thunar with gvfs support
Wouln't it make sense to make the 1.1 branch an option of the regular
thunar spell? Thunar 1.1 doesn't seem to be a distinct project but
simply a newer version of thunar.

Florian

Attachment: signature.asc
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page