Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Andraž Levstik (ab4c6b4e266c51bcde7e809b6fb2332fffe81ff3)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: flux <flux AT sourcemage.org>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Andraž Levstik (ab4c6b4e266c51bcde7e809b6fb2332fffe81ff3)
  • Date: Wed, 18 Nov 2009 12:35:47 -0500

Andraž Levstik (scm AT sourcemage.org) wrote [09.11.17 13:33]:
> GIT changes to master grimoire by Andraž Levstik
> <ruskie+2054d253 AT codemages.net>:
>
> libs/libvirt/CONFIGURE | 5 -----
> libs/libvirt/DEPENDS | 5 +++++
> libs/libvirt/HISTORY | 4 ++--
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
> New commits:
> commit ab4c6b4e266c51bcde7e809b6fb2332fffe81ff3
> Author: Andraž Levstik <ruskie+2054d253 AT codemages.net>
> Commit: Andraž Levstik <ruskie+2054d253 AT codemages.net>
>
> libvirt: moved query, thanks sandalle
>
> diff --git a/libs/libvirt/CONFIGURE b/libs/libvirt/CONFIGURE
> index 65cc7d4..0341da3 100755
> --- a/libs/libvirt/CONFIGURE
> +++ b/libs/libvirt/CONFIGURE
> @@ -22,11 +22,6 @@ config_query_option LIBVIRT_OPTS 'Build VirtualBox
> support' y \
> config_query_option LIBVIRT_OPTS 'Build User Mode Linux support' y \
> '--with-uml' '--without-uml' &&
>
> -if is_depends_enabled $SPELL xen ; then
> -config_query_option LIBVIRT_OPTS 'Enable Xen inotify support' y \
> - '--with-xen-inotify' '--without-xen-inotify'
> -fi &&
> -
> config_query_option LIBVIRT_OPTS 'Build remote driver support?' y \
> '--with-remote' '--without-remote' &&
>
> diff --git a/libs/libvirt/DEPENDS b/libs/libvirt/DEPENDS
> index 9b11020..bfc8219 100755
> --- a/libs/libvirt/DEPENDS
> +++ b/libs/libvirt/DEPENDS
> @@ -30,6 +30,11 @@ optional_depends xen-tools \
> '--without-xen' \
> 'for Xen support' &&
>
> +if is_depends_enabled $SPELL xen ; then
> +config_query_option LIBVIRT_OPTS 'Enable Xen inotify support' y \
> + '--with-xen-inotify' '--without-xen-inotify'
> +fi &&
> +
> optional_depends lvm \
> '--with-storage-lvm' \
> '--without-storage-lvm' \
> diff --git a/libs/libvirt/HISTORY b/libs/libvirt/HISTORY
> index fa0afbf..0d3f037 100644
> --- a/libs/libvirt/HISTORY
> +++ b/libs/libvirt/HISTORY
> @@ -1,7 +1,7 @@
> 2009-11-17 Andraž "ruskie" Levstik <ruskie+f03a580f AT codemages.net>
> * DETAILS: updated spell to 0.7.2
> - * CONFIGURE: updated
> - * DEPENDS: updated
> + * CONFIGURE: updated, moved xen inotify
> + * DEPENDS: updated, moved xen inotify
> * SUB_DEPENDS: added
> * PRE_SUB_DEPENDS: added

According to http://www.sourcemage.org/Things_Spells_Should_Not_Do,
spells aren't supposed to query anywhere other CONFIGURE, SUB_DEPENDS,
or PREPARE. Personally I think we should query in DEPENDS in cases like
this, but the doc says not to. Should we follow the doc and change spell
practice, or update the doc?

--
Justin "flux_control" Boffemmyer
Cauldron wizard and general mage
Source Mage GNU/Linux
http://www.sourcemage.org

Attachment: pgpf97ppiAZ3v.pgp
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page