Skip to Content.
Sympa Menu

sm-commit - [SM-Commit] GIT changes to master grimoire by George Sherwood (9504c298a5c54db9a5b39f1eab998c3248c0e789)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: George Sherwood <scm AT sourcemage.org>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: [SM-Commit] GIT changes to master grimoire by George Sherwood (9504c298a5c54db9a5b39f1eab998c3248c0e789)
  • Date: Sun, 8 Nov 2009 21:35:56 -0600

GIT changes to master grimoire by George Sherwood <gsherwood AT sourcemage.org>:

dev/null |binary
disk/cdrtools/CONFIGURE | 1
disk/cdrtools/DETAILS | 65
++++++++++++++----------
disk/cdrtools/HISTORY | 20 +++++++
disk/cdrtools/INSTALL | 3 -
disk/cdrtools/PRE_BUILD | 13 +---
disk/cdrtools/cdrtools-2.01.01a01-scanbus.patch | 25 ---------
disk/cdrtools/cdrtools-2.01.01a03-rezero.patch | 23 --------
disk/cdrtools/cdrtools-2.01.01a30.tar.bz2.sig | 0
disk/cdrtools/patch_cdrecord_for_suid | 55 --------------------
10 files changed, 63 insertions(+), 142 deletions(-)

New commits:
commit 9504c298a5c54db9a5b39f1eab998c3248c0e789
Author: George Sherwood <gsherwood AT sourcemage.org>
Commit: George Sherwood <gsherwood AT sourcemage.org>

cdrtools: Updated to version 2.01.01a67 and other changes
to fix Bug #15316.

diff --git a/disk/cdrtools/CONFIGURE b/disk/cdrtools/CONFIGURE
index e4f4665..6bfb5a5 100755
--- a/disk/cdrtools/CONFIGURE
+++ b/disk/cdrtools/CONFIGURE
@@ -3,6 +3,5 @@ config_query IDE_SCSI
\
n
&&
config_query_list PERM
\
"Giving write permission to IDE devices can be risky, whom do
you want to allow this?" \
- "burning_group_users"
\
"root_only"
\
"burning_group_users_with_suid_bit"
diff --git a/disk/cdrtools/DETAILS b/disk/cdrtools/DETAILS
index ed13b2a..df1dd66 100755
--- a/disk/cdrtools/DETAILS
+++ b/disk/cdrtools/DETAILS
@@ -1,42 +1,53 @@
SPELL=cdrtools
- VERSION=2.01.01a30
- PATCHLEVEL=1
+ VERSION=2.01.01a67
+# PATCHLEVEL=1
ALPHA=$([ "${VERSION//a/}" != "$VERSION" ] && echo 1)
- SOURCE=${SPELL}-${VERSION}.tar.bz2
+ SOURCE=${SPELL}-${VERSION}.tar.gz
SOURCE_DIRECTORY=${BUILD_DIRECTORY}/${SPELL}-${VERSION%a*}
SOURCE_URL[0]=ftp://ftp.berlios.de/pub/cdrecord/${ALPHA:+alpha/}${SOURCE}
-#
SOURCE_HASH=sha512:2d1a52c6d9e6fa751ce1e16f0fd30bece0e57c0b7148988da3f1c05dcd2a69d7f6f9f9a7880a92320f51e4b84dddeced03cd28ce3f27478ccc6c2853db98d786
- SOURCE_GPG="gurus.gpg:${SOURCE}.sig:WORKS_FOR_ME"
+#
SOURCE_HASH=sha512:2d1a52c6d9e6fa751ce1e16f0fd30bece0e57c0b7148988da3f1c05dcd2a69d7f6f9f9a7880a92320f51e4b84dddeced03cd28ce3f27478ccc6c2853db98d786
+
SOURCE_HASH=sha512:43cc122efaf734eff309ec7dc12082c02b7954d9e9b3a6c6a656511b291cea2bf6ea757222750db31133c44c91297ae2832a23a6aed4fcd5d2857c6777bca642
+# SOURCE_GPG="gurus.gpg:${SOURCE}.sig:WORKS_FOR_ME"
LICENSE[0]=GPL
KEYWORDS="disk"
- WEB_SITE=http://cdrecord.berlios.de/old/private/cdrecord.html
+ WEB_SITE=http://cdrecord.berlios.de/private/cdrecord.html
ENTERED=20010922
- SHORT="Create home-burned CDs with a CD-R/CD-RW recorder"
+ SHORT="Cdrtools - Highly portable CD/DVD/BluRay command line
recording software"
cat << EOF
-cdrtools, formerly Cdrecord creates home-burned CDs with a CD-R/CD-RW
-recorder. It works as a burn engine for several applications. Cdrecord
-supports CD recorders from many different vendors; all SCSI-3/mmc and
-ATAPI/mmc compliant drives should also work. Supported features include
-IDE/ATAPI, parallel-port, and SCSI drives, audio CDs, data CDs, and
-mixed CDs, full multi-session support, CD-RWs (rewritable), TAO, DAO and
-human-readable error messages. Cdrecord includes remote SCSI support and
-can access local or remote CD-writers.
+Cdrtools is a set of command line programs that allows to record
CD/DVD/BluRay media.

-Giving the permission to burn a CD-R/CD-RW can be risky. Since CD-R/CD-RW
+The suite includes the following programs:
+
+cdrecord A CD/DVD/BD recording program
+readcd A program to read CD/DVD/BD media with CD-clone features
+cdda2wav The most evolved CD-audio extraction program with paranoia
support
+mkisofs A program to create hybrid ISO9660/JOLIET/HFS filesystes with
optional Rock Ridge attributes
+isodebug A program to print mkisofs debug information from media
+isodump A program to dump ISO-9660 media
+isoinfo A program to analyse/verify ISO/9660/Joliet/Rock-Ridge
Filesystems
+isovfy A program to verify the ISO-9660 structures
+rscsi A Remote SCSI enabling daemon
+
+Giving the permission to burn a CD/DVD/BD can be risky. Since CD/DVD/BD
recorder is an IDE or SCSI device, it is possible to use cdrecord command
-with a hard disk, which would cause damage. So it is recommended to allow
+with a hard disk, which would cause damage. So it is recommended to allow
only root or specific users to burn.
-The spell will prompt you three choices to do this :
- [0] : Allow users from the burning group to burn (default)
- [1] : Only allow root to burn
- [2] : Allow users from the burning group to burn, with the suid-bit set.
- This way cdrecord process will have a higher priority as if it
- run as root. This can be useful with some old CD-R/CD-RW recorders
- which don't have burnfree/buffer underrun protection. Cdrecord will
- be patched to pass through kernel security limitations.
-If you choose [0] or [2], you will have then to add users in the burning
+
+The spell will prompt you two choices to do this :
+
+ [0] : Only allow root to burn
+ [1] : Allow users from the burning group to burn, with the suid-bit set.
+ This way cdrecord process will have a higher priority as if it
+ run as root. This can be useful with some old CD-R/CD-RW recorders
+ which don't have burnfree/buffer underrun protection.
+
+If you choose [1], you will have then to add users in the burning
group that the spell creates. Write permission for the burning group on the
-CD-R/CD-RW recorder must be gived. This is done automatically by the spell
+CD/DVD/BD recorder must be gived. This is done automatically by the spell
scripts in differents ways, according do the device management system
you use. Please NOTE that you have to do this manually with DEVFSD at this
time.
+
+If other users than root should be allowed to execute rscsi they need an
+entry in /etc/default/rscsi. If you do not change that entry, you should
+create a user rscsi.
EOF
diff --git a/disk/cdrtools/HISTORY b/disk/cdrtools/HISTORY
index 080177b..c7ab00c 100644
--- a/disk/cdrtools/HISTORY
+++ b/disk/cdrtools/HISTORY
@@ -1,3 +1,23 @@
+2009-11-08 Javier Vasquez <j.e.vasquez.v AT gmail.com>
+ * DETAILS: Updating version to 2.01.01a67. Bug #15316
+ Updating the information regarding cdrtools (old
+ one was pretty out of date).
+ Commenting out the PATCH stuff, since the suid one is
+ no longer required, and the rest are pretty much
+ broken. See not from site:
+ "Important information: Linux-2.6.8.1 breaks CD/DVD
+ writing for suid root applications. If you have related
+ problems, use a recent original cdrecord and install
+ cdrecord suid-root"
+ Adding note about rscsi usage.
+ * CONFIGURE: Removing the group permissions option
+ since the patches required are broken.
+ * PRE_BUILD: Removing all patching.
+ Changing sed commands by sedit ones.
+ * cdrtools-2.01.01a01-scanbus.patch: Removed (broken).
+ * cdrtools-2.01.01a03-rezero.patch: Removed (broken).
+ * patch_cdrecord_for_suid: Removed (no longer needed).
+
2009-06-04 Jaka Kranjc <lynxlynxlynx AT sourcemage.org>
* DETAILS: PATCHLEVEL++
* UP_TRIGGERS: added to heal dvd-rw-tools after dispelling -
diff --git a/disk/cdrtools/INSTALL b/disk/cdrtools/INSTALL
index 348baf1..1874dea 100755
--- a/disk/cdrtools/INSTALL
+++ b/disk/cdrtools/INSTALL
@@ -1,5 +1,4 @@
# make install uses bin group/user
create_account bin &&
-make INS_BASE=${INSTALL_ROOT}/usr install &&
-
+make INS_BASE=${INSTALL_ROOT}/usr install &&
apply_cdr_perms ${PERM} ${INSTALL_ROOT}/usr/bin/cdrecord
diff --git a/disk/cdrtools/PRE_BUILD b/disk/cdrtools/PRE_BUILD
index 4df229f..85565c8 100755
--- a/disk/cdrtools/PRE_BUILD
+++ b/disk/cdrtools/PRE_BUILD
@@ -1,11 +1,6 @@
default_pre_build &&
cd ${SOURCE_DIRECTORY} &&
-sed -i "s:/usr/src/linux/include::" DEFAULTS/Defaults.linux &&
-sed -i "s:/opt/schily:/usr:g" DEFAULTS/Defaults.linux &&
-sed -i "s:/usr/src/linux/include::g" DEFAULTS/Defaults.linux &&
-sed -i "1iMANDIR= share/man" RULES/rules.man &&
-case ${PERM} in
- burning_group_users) patch -p1 <
$SPELL_DIRECTORY/cdrtools-2.01.01a01-scanbus.patch &&
- patch -p1 <
$SPELL_DIRECTORY/cdrtools-2.01.01a03-rezero.patch ;;
- burning_group_users_with_suid_bit) patch -p1 <
$SPELL_DIRECTORY/patch_cdrecord_for_suid ;;
-esac
+sedit "s:/usr/src/linux/include::i" DEFAULTS/Defaults.linux &&
+sedit "s:/opt/schily:/usr:gi" DEFAULTS/Defaults.linux &&
+sedit "s:/usr/src/linux/include::gi" DEFAULTS/Defaults.linux &&
+sedit "1iMANDIR= share/man" RULES/rules.man
diff --git a/disk/cdrtools/cdrtools-2.01.01a01-scanbus.patch
b/disk/cdrtools/cdrtools-2.01.01a01-scanbus.patch
deleted file mode 100644
index 9b2dcb2..0000000
--- a/disk/cdrtools/cdrtools-2.01.01a01-scanbus.patch
+++ /dev/null
@@ -1,25 +0,0 @@
-diff -Naur cdrtools-2.01.01.orig/libscg/scsi-linux-ata.c
cdrtools-2.01.01/libscg/scsi-linux-ata.c
---- cdrtools-2.01.01.orig/libscg/scsi-linux-ata.c 2007-07-09
10:56:56.113108163 -0700
-+++ cdrtools-2.01.01/libscg/scsi-linux-ata.c 2007-07-09 10:57:29.108074574
-0700
-@@ -394,7 +394,8 @@
- "try open(%s) return %i,
errno %i, cancel\n",
- device, f, errno);
- }
-- return (-2);
-+ /* return (-2); */
-+ break;
- } else if (errno == ENOENT || errno ==
ENODEV) {
- break;
- }
-diff -Naur cdrtools-2.01.01.orig/libscg/scsi-linux-sg.c
cdrtools-2.01.01/libscg/scsi-linux-sg.c
---- cdrtools-2.01.01.orig/libscg/scsi-linux-sg.c 2007-07-09
10:56:56.113108163 -0700
-+++ cdrtools-2.01.01/libscg/scsi-linux-sg.c 2007-07-09 10:57:29.108074574
-0700
-@@ -464,7 +464,7 @@
- if (scgp->errstr)
- js_snprintf(scgp->errstr,
SCSI_ERRSTR_SIZE,
- "Cannot open '%s'",
devname);
-- return (0);
-+ //return (0);
- }
- } else {
- int iparm;
diff --git a/disk/cdrtools/cdrtools-2.01.01a03-rezero.patch
b/disk/cdrtools/cdrtools-2.01.01a03-rezero.patch
deleted file mode 100644
index fd9faaa..0000000
--- a/disk/cdrtools/cdrtools-2.01.01a03-rezero.patch
+++ /dev/null
@@ -1,23 +0,0 @@
---- cdrtools-2.01.01/cdrecord/cdrecord.c.orig 2007-07-19 18:50:02.000000000
+0200
-+++ cdrtools-2.01.01/cdrecord/cdrecord.c 2007-07-19 18:51:17.000000000
+0200
-@@ -4214,16 +4214,17 @@
- * with e.g. vendor unique commands, where cdrecord would miss
- * functionality or fail completely after starting to write.
- */
-+ /* kernel >= 2.6.12 does not like that as user
- seterrno(0);
- scgp->silent++;
-- code = rezero_unit(scgp); /* Not supported by some drives */
-+ code = rezero_unit(scgp);
- scgp->silent--;
- err = geterrno();
- if (code < 0 && (err == EPERM || err == EACCES)) {
-- linuxcheck(); /* For version 1.349 of cdrecord.c */
-+ linuxcheck();
- scg_openerr("");
- }
--
-+ */
-
- test_unit_ready(scgp);
- scsi_start_stop_unit(scgp, 1, 0, immed);
diff --git a/disk/cdrtools/cdrtools-2.01.01a30.tar.bz2.sig
b/disk/cdrtools/cdrtools-2.01.01a30.tar.bz2.sig
deleted file mode 100644
index e286a01..0000000
Binary files a/disk/cdrtools/cdrtools-2.01.01a30.tar.bz2.sig and /dev/null
differ
diff --git a/disk/cdrtools/patch_cdrecord_for_suid
b/disk/cdrtools/patch_cdrecord_for_suid
deleted file mode 100644
index c87e359..0000000
--- a/disk/cdrtools/patch_cdrecord_for_suid
+++ /dev/null
@@ -1,55 +0,0 @@
-diff -Naur cdrtools-2.01.01.orig/cdrecord/cdrecord.c
cdrtools-2.01.01/cdrecord/cdrecord.c
---- cdrtools-2.01.01.orig/cdrecord/cdrecord.c 2007-07-09 10:56:55.613184429
-0700
-+++ cdrtools-2.01.01/cdrecord/cdrecord.c 2007-07-09 10:59:55.585728489
-0700
-@@ -517,8 +517,10 @@
- *
- * XXX Below this point we do not need root privilleges anymore.
- */
-- if (geteuid() != getuid()) { /* AIX does not like to do this */
-- /* If we are not root */
-+ // fixing issue with kernel >= 2.6.8.1
-+ // if (geteuid() != getuid()) { /* AIX does not like to do
this */
-+ /* If we are not root
*/
-+ /*
- #ifdef HAVE_SETREUID
- if (setreuid(-1, getuid()) < 0)
- #else
-@@ -530,6 +532,7 @@
- #endif
- comerr("Panic cannot set back effective uid.\n");
- }
-+*/
- /*
- * WARNING: We now are no more able to do any privilleged operation
- * unless we have been called by root.
-@@ -1106,10 +1109,13 @@
- * even on OS that do not support getreuid() which is *BSD
- * and SUSv3 only.
- */
-- if (oeuid != getuid()) {
-+ // fixing issue with kernel >= 2.6.8.1
-+ /*
-+ if (oeuid != getuid()) {
- if (setreuid(-1, oeuid) < 0)
- errmsg("Could set back effective uid.\n");
- }
-+ */
- #endif
- /*
- * fork() here to start the extra process needed for
-@@ -1124,11 +1130,14 @@
- /*
- * XXX Below this point we never need root privilleges
anymore.
- */
-- if (geteuid() != getuid()) { /* AIX does not like to do
this */
-+ // fixing issue with kernel >= 2.6.8.1
-+ // if (geteuid() != getuid()) { /* AIX does
not like to do this */
- /* If we are not root
*/
-+ /*
- if (setreuid(-1, getuid()) < 0)
- comerr("Panic cannot set back effective
uid.\n");
- }
-+ */
- #endif
- }
- if ((*dp->cdr_set_speed_dummy)(scgp, dp, &speed) < 0) {



  • [SM-Commit] GIT changes to master grimoire by George Sherwood (9504c298a5c54db9a5b39f1eab998c3248c0e789), George Sherwood, 11/08/2009

Archive powered by MHonArc 2.6.24.

Top of Page