Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master games grimoire by Eric Sandall (a02804f237cd1c9a8b3546cf1fa2581935729997)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Ladislav Hagara <ladislav.hagara AT unob.cz>
  • To: Eric Sandall <sandalle AT sourcemage.org>
  • Cc: "sm-commit AT lists.ibiblio.org" <sm-commit AT lists.ibiblio.org>
  • Subject: Re: [SM-Commit] GIT changes to master games grimoire by Eric Sandall (a02804f237cd1c9a8b3546cf1fa2581935729997)
  • Date: Mon, 29 Jun 2009 14:52:40 +0200


> tong: Somehow Bug #10642 is back, though it was fixed three years ago
>
> diff --git a/games-arcade-2d/tong/HISTORY b/games-arcade-2d/tong/HISTORY
> index 32f12ce..cb6d6ca 100644
> --- a/games-arcade-2d/tong/HISTORY
> +++ b/games-arcade-2d/tong/HISTORY
> @@ -1,3 +1,6 @@
> +2009-06-22 Eric Sandall <sandalle AT sourcemage.org>
> + * INSTALL: Somehow Bug #10642 is back, though it was fixed three
> years ago
> +
> 2006-09-21 Andraž "ruskie" Levstik <ruskie AT mages.ath.cx>
> * DETAILS: [automated] Removed BUILD_API=2.
>
> diff --git a/games-arcade-2d/tong/INSTALL b/games-arcade-2d/tong/INSTALL
> index f44e9bc..41cec4f 100755
> --- a/games-arcade-2d/tong/INSTALL
> +++ b/games-arcade-2d/tong/INSTALL
> @@ -1,8 +1,7 @@
> TONG_DIR=/usr/share/games/$SPELL &&
> install -d -m 755 -o root -g games $TONG_DIR &&
> -chown -R games:root * &&
> +chown -R root:games * &&
> cp -r media $TONG_DIR &&
> cp tong $TONG_DIR &&
> install -m 755 -o root -g games \
> - $SCRIPT_DIRECTORY/tong /usr/games &&
> -chmod u+s /usr/games/tong
> + $SCRIPT_DIRECTORY/tong /usr/games


$ git show a73211a20057ecddb67d3a0cabc0f03cf38aec35
Date: Fri Mar 10 17:37:34 2006 +0000
* INSTALL: Owner is root, not games, and group is games, not root
(Bug #10642)
-chown -R games.root * &&
+chown -R games:root * &&


Seems this really wasn't fixed in 2006.
Our review process wasn't so good as it is now. :-)

--
Ladislav Hagara









Archive powered by MHonArc 2.6.24.

Top of Page