Source Mage code commit list

[Remko van der Vossen <wich AT yuugen.jp>]

I guess the gist of this discussion and previous discussions about
similar topics is this:

On Thu, Apr 23, 2009 at 10:06:57AM -0700, Eric Sandall wrote:
> but reverting others changes because you disagree with them is not
> cool, in my opinion.

It might not be stated anywhere as policy, but really it's just common
decency and politeness. Do not simply revert something you don't agree
with, for whichever reason. Whether the reason is valid or not is not
the question. Instead discuss the change, bring it up with the committer
and possibly the rest of the community through the mailing lists or
bugzilla.

I see only two reasons for reverting a commit without discussion:
  - if it has been made clear upfront that certain commits will be
    reverted, e.g. changes in a certain section in master for which
    announced ongoing development is happening in a devel branch.
  - when the commit causes a demonstrable compile or runtime problem,
    which is not due to the particular setup, i.e. a specific
    combination of spells/versions installed, a specific software
    configuration, a specific piece of hardware, etc.

So in short, yes there are valid reasons for reverting a commit, yes
some commits should be reverted, but no, none of us are the sole
authority to decide whether a commit should be reverted or not.

Disclaimer: While the above is written in a definitive voice, it is
merely my opinion.

Regards, Remko van der Vossen.

Attachment: pgpjwP7VebG73.pgp
Description: PGP signature