sm-commit AT lists.ibiblio.org
Subject: Source Mage code commit list
List archive
Re: [SM-Commit] GIT changes to master grimoire by Ethan Grammatikidis (89dedea8a196888e0d61887d2b2338a6ab37d292)
- From: "Ethan Grammatikidis" <eekee57 AT fastmail.fm>
- To: "Arwed von Merkatz" <v.merkatz AT gmx.net>, sm-commit AT lists.ibiblio.org
- Subject: Re: [SM-Commit] GIT changes to master grimoire by Ethan Grammatikidis (89dedea8a196888e0d61887d2b2338a6ab37d292)
- Date: Sat, 24 Jan 2009 14:16:26 +0000
On Wed, 21 Jan 2009 16:27:57 +0100, "Arwed von Merkatz"
<v.merkatz AT gmx.net> said:
> On Wed, Jan 21, 2009 at 12:53:06AM +0000, Ethan Grammatikidis wrote:
> [...]
> > Also I currently feel like I'll still be defending this when I go to my
> > grave. Whatever happened to "we don't patch unless it's essential?"
> > [...]
>
> Making it build is what I consider 'essential'. And this patch fixed
> build errors others were having, so it's perfectly valid. If it breaks
> for you, you're of course welcome to find a way to make it work for
> everyone.
I'm sorry for my snarky comment. I did extensive testing, and found xorg
was fairly logical about when it required mesalib and with which options
without the patch, so I assumed George hadn't tested thoroughly. However
he assures me that it is needed to make xorg-server build on some of his
machines.
Now, *somehow* the patch manages to break xorg-server compile on my
machine. Therefore it may also break xorg-server on some other people's
machines, therefore it should not be mandatory in stable.
There appears to be no rational (or at least discoverable) logic to when
this patch is needed *or* when it will break compilation, so the only
way forward seems to be to make the patch optional and let our poor
users muddle through by trial and error. I repeat my request for my
commit making the patch optional to be integrated into stable.
--
This post brought to you by:
Ethan Grammatikidis,
who follows directions like a butterfly.
-
[SM-Commit] GIT changes to master grimoire by Ethan Grammatikidis (89dedea8a196888e0d61887d2b2338a6ab37d292),
Ethan Grammatikidis, 01/20/2009
-
Re: [SM-Commit] GIT changes to master grimoire by Ethan Grammatikidis (89dedea8a196888e0d61887d2b2338a6ab37d292),
Jaka Kranjc, 01/20/2009
-
Re: [SM-Commit] GIT changes to master grimoire by Ethan Grammatikidis (89dedea8a196888e0d61887d2b2338a6ab37d292),
Ethan Grammatikidis, 01/20/2009
- Re: [SM-Commit] GIT changes to master grimoire by Ethan Grammatikidis (89dedea8a196888e0d61887d2b2338a6ab37d292), George Sherwood, 01/21/2009
-
Re: [SM-Commit] GIT changes to master grimoire by Ethan Grammatikidis (89dedea8a196888e0d61887d2b2338a6ab37d292),
Arwed von Merkatz, 01/21/2009
- Re: [SM-Commit] GIT changes to master grimoire by Ethan Grammatikidis (89dedea8a196888e0d61887d2b2338a6ab37d292), Ethan Grammatikidis, 01/24/2009
-
Re: [SM-Commit] GIT changes to master grimoire by Ethan Grammatikidis (89dedea8a196888e0d61887d2b2338a6ab37d292),
Ethan Grammatikidis, 01/20/2009
-
Re: [SM-Commit] GIT changes to master grimoire by Ethan Grammatikidis (89dedea8a196888e0d61887d2b2338a6ab37d292),
Jaka Kranjc, 01/20/2009
Archive powered by MHonArc 2.6.24.