sm-commit AT lists.ibiblio.org
Subject: Source Mage code commit list
List archive
Re: [SM-Commit] GIT changes to master grimoire by Florian Franzmann (01991524c49666ea341d4f8854f5f70934f3a25e)
- From: "Eric Sandall" <eric AT sandall.us>
- To: sm-commit AT lists.ibiblio.org
- Subject: Re: [SM-Commit] GIT changes to master grimoire by Florian Franzmann (01991524c49666ea341d4f8854f5f70934f3a25e)
- Date: Mon, 17 Nov 2008 15:25:14 -0800
Quoting "Ladislav Hagara" <ladislav.hagara AT unob.cz>:
Preferably, revert the incorrect commit and then redo correctly, that
way integrations may be done with one commit, rather than two.
It is arguable. What is more important for us, easy integrations or
easy mail reviews?
I really dislike mails with tens of commits (reverting revert which had
reverted ...) ending with small change.
I think integrations should be made as clean as possible, but that's just my opinion. :) If you want a clean commit, you can always use `git show <commit id>`. Also, at some point I believe we'll be having each commit a separate e-mail, so the "messiness" you're complaining about will be gone. :)
-sandalle
--
Eric Sandall | Source Mage GNU/Linux Developer
eric AT sandall.us PGP: 0xA8EFDD61 | http://www.sourcemage.org/
http://eric.sandall.us/ | http://counter.li.org/ #196285
-
[SM-Commit] GIT changes to master grimoire by Florian Franzmann (01991524c49666ea341d4f8854f5f70934f3a25e),
Florian Franzmann, 11/16/2008
-
Re: [SM-Commit] GIT changes to master grimoire by Florian Franzmann (01991524c49666ea341d4f8854f5f70934f3a25e),
Eric Sandall, 11/17/2008
-
Re: [SM-Commit] GIT changes to master grimoire by Florian Franzmann (01991524c49666ea341d4f8854f5f70934f3a25e),
Ladislav Hagara, 11/17/2008
- Re: [SM-Commit] GIT changes to master grimoire by Florian Franzmann (01991524c49666ea341d4f8854f5f70934f3a25e), Eric Sandall, 11/17/2008
-
Re: [SM-Commit] GIT changes to master grimoire by Florian Franzmann (01991524c49666ea341d4f8854f5f70934f3a25e),
Ladislav Hagara, 11/17/2008
-
Re: [SM-Commit] GIT changes to master grimoire by Florian Franzmann (01991524c49666ea341d4f8854f5f70934f3a25e),
Eric Sandall, 11/17/2008
Archive powered by MHonArc 2.6.24.