Source Mage code commit list

[Eric Sandall <eric AT sandall.us>]

On Thu, 30 Oct 2008 12:11:22 -0500
Jeremy Blosser <jblosser-smgl AT firinn.org> wrote:

> On Oct 30, Vlad Glagolev [scm AT sourcemage.org] wrote:
> > New commits:
> > commit 75e1171e887c265ec9a6288a3fef2e57c86c9a97
> > Author: Vlad Glagolev <stealth AT sourcemage.org>
> > Commit: Vlad Glagolev <stealth AT sourcemage.org>
> > 
> >     wpa_supplicant: mass fix.
> 
> I may have missed a memo in the times I've been less around, but last
> I knew we didn't have formal formatting guidelines for spells beyond
> "if you edit a spell please try to keep it consistent with what's
> there; if you 'take over' a spell change it to what works best for
> you".  I don't consider a ton of formatting changes from what was
> there for years to what you think is best "fixes" or even "cleanups",
> I consider them noise.  It's nearly impossible to review a commit
> like this for actual changes and there's plenty of opportunities to
> have introduced breakage even in the changes that aren't supposed to
> alter functionality.

I agree.

We do have standards, they are in places such as
http://www.sourcemage.org/DEPENDS and http://www.sourcemage.org/DETAILS
(which only mentions 80 columns for the long description, though that
has been informally adopted by *all other devs* for the rest of the
files).

Please do not re-format packages to suite your individual needs when
the rest of the project has been keeping them fairly consistent. It's
especially funny (not really) when someone changes all the "&&" spacing
that has been in place for *seven* years because they don't like all
the spaces.

If you want a change, bring it up in SM-Discuss and we can discuss it,
otherwise, please try to follow the prevailing format as doing
otherwise just causes more work for the rest of us.

-sandalle

-- 
Eric Sandall                     |  Source Mage GNU/Linux Developer
eric AT sandall.us PGP: 0xA8EFDD61  |  http://www.sourcemage.org/
http://eric.sandall.us/          |  http://counter.li.org/  #196285

Attachment: signature.asc
Description: PGP signature