Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Vlad Glagolev (e021205d75782531e46de703d4fc7151c56beeb5)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Robin Cook <rcook AT wyrms.net>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Vlad Glagolev (e021205d75782531e46de703d4fc7151c56beeb5)
  • Date: Sun, 02 Nov 2008 08:32:30 -0600

I know I have asked you not to make these formatting changes in the gnome spells I maintain.

I have been using the format in the gnome spells since I took over the gnome section in 2002 and I prefer it as it helps me verify that I didn't miss a line etc.

Robin Cook
CuZnDragon

On Fri, 2008-10-31 at 22:00 +0300, Vlad Glagolev wrote:
> It's not useless chars to many people, and it's been common practice for a
> very long time.

Have you ever heard about some sweet term -- "clean code" ?
And let those "many people" prove that it's really "common practice for a very long time".

Since we've not been having the strict rules for formatting, I can't do this:
> Please don't do this anymore.

Neither me, no other devs/users (you can ask them on IRC or read theirs answers @ MLs) want
to go through the jungles of spaces to change/fix something in code.

> Yes, I'd prefer you revert that commit and redo it with just the functional
> changes included instead of all the formatting changes.

By saying "fix" I didn't mean "revert", I meant "FIX". Fix the problem I made with that commit -
align the lines and cut theirs length to 80 chars.

_______________________________________________
SM-Commit mailing list
SM-Commit AT lists.ibiblio.org
http://lists.ibiblio.org/mailman/listinfo/sm-commit

Attachment: signature.asc
Description: This is a digitally signed message part



  • Re: [SM-Commit] GIT changes to master grimoire by Vlad Glagolev (e021205d75782531e46de703d4fc7151c56beeb5), Robin Cook, 11/02/2008

Archive powered by MHonArc 2.6.24.

Top of Page