Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Vlad Glagolev (75e1171e887c265ec9a6288a3fef2e57c86c9a97)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Jeremy Blosser <jblosser-smgl AT firinn.org>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Vlad Glagolev (75e1171e887c265ec9a6288a3fef2e57c86c9a97)
  • Date: Thu, 30 Oct 2008 12:11:22 -0500

On Oct 30, Vlad Glagolev [scm AT sourcemage.org] wrote:
> New commits:
> commit 75e1171e887c265ec9a6288a3fef2e57c86c9a97
> Author: Vlad Glagolev <stealth AT sourcemage.org>
> Commit: Vlad Glagolev <stealth AT sourcemage.org>
>
> wpa_supplicant: mass fix.

I may have missed a memo in the times I've been less around, but last I
knew we didn't have formal formatting guidelines for spells beyond "if you
edit a spell please try to keep it consistent with what's there; if you
'take over' a spell change it to what works best for you". I don't
consider a ton of formatting changes from what was there for years to what
you think is best "fixes" or even "cleanups", I consider them noise. It's
nearly impossible to review a commit like this for actual changes and
there's plenty of opportunities to have introduced breakage even in the
changes that aren't supposed to alter functionality.

> - config_query CONFIG_CTRL_IFACE
> \
> - "Build external control interface?"
> \
> - y
> &&
> - config_query CONFIG_DNET_PCAP
> \
> - "Use libpcap/libdnet instead of native Linux packet socket
> \
> -interface?"
> \
> - n
> + config_query CONFIG_CTRL_IFACE "Build external control interface?" y &&
> + config_query CONFIG_DNET_PCAP "Use libpcap/libdnet instead of native
> Linux packet socket interface?" n

In particular I really do not consider changes that cause lines to wrap or
run together as at all useful. Some of us still use 80 column terminals on
purpose and prefer things to line up correctly. In any case a lot of
people prefer things to look segmented even if it means the spacing is not
consistent; shell formatting is not an exact science. If I later edited
this file I'd be inclined to "clean it up" by putting it back like how it
was. But I'd rather not see us become the kind of distro that has to adopt
formatting standards to avoid those kind of edit wars, because that's the
kind of waste of time that takes away from real work.

Attachment: pgpCziGoWbCG_.pgp
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page