Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Eric Sandall (e41ba9e08c0389866dd7084e8a94c7db42ee601f)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Eric Sandall <eric AT sandall.us>
  • To: Ladislav Hagara <ladislav.hagara AT unob.cz>
  • Cc: "sm-commit AT lists.ibiblio.org" <sm-commit AT lists.ibiblio.org>
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Eric Sandall (e41ba9e08c0389866dd7084e8a94c7db42ee601f)
  • Date: Tue, 14 Oct 2008 03:38:22 -0700

On Tue, 14 Oct 2008 10:28:19 +0200
Ladislav Hagara <ladislav.hagara AT unob.cz> wrote:

>
> > GIT changes to master grimoire by Eric Sandall
> > <sandalle AT sourcemage.org>:
> >
> > +++ b/e-17/eina/CONFIGURE
> >
> > +if [[ "$EINA_BENCHMARK" == "--enable-benchmark" ]]; then
> > + config_query_option EINA_E17 "Enable heavy benchmarks (fake
> > E17 data)?" y \
> > + '--disable-e17' '--enable-e17'
> > +fi
> >
>
> I didn't check, is the order OK, --disable-e17 and --enable-e17 ?

Yeah, it's worded weird, but correct as far as I could figure.

--enable-e17 *disables* heavy benchmarks and compiling heavy benchmarks
is the default (I assume, since the flag said to use '--enable-e17' to
disable).

> > diff --git a/e-17/eina/DEPENDS b/e-17/eina/DEPENDS
> > new file mode 100755
> > index 0000000..d51738e
> > --- /dev/null
> > +++ b/e-17/eina/DEPENDS
> >
> > +if [[ "$EINA_BENCHMARK" == "--enable-benchmark" ]]; then
> > + optional_depends "glib" "" "" "for Glib benchmarks" &&
> > + optional_depends "evas" "" "" "for Evas benchmarks" &&
> > + optional_depends "ecore" "" "" "for Ecore benchmarks"
> > +fi
> >
>
> Evas and ecore depends on eina. Eina optional_depends on them.
> Potential problems. suggest_depends?

Fun circular logic. Does suggest_depends "fix" circular dependencies
such as this?

> > +++ b/e-17/eina/PRE_BUILD
> > @@ -0,0 +1,8 @@
> > +default_pre_build &&
> > +cd $SOURCE_DIRECTORY &&
> > +#
> > +# Remove .svn directories, otherwise they get installed
> > +#
> > +find . -type d -name .svn -exec rm -rf {} \; 2>/dev/null || true
> > &&
>
> Something like this should probably go to FUNCTION for all svn spells.
> For example ecore, evas, ... also
> install /usr/share/doc/ecore/doc/.svn
> and /usr/share/doc/ecore/doc/img/.svn (copies of all pictures).

Not all packages do this. I checked the ones I have installed and fixed
the ones that did. Note that none of the e_module-* packages install
these .svn directories and they're checked out from Subversion.

-sandalle

--
Eric Sandall | Source Mage GNU/Linux Developer
eric AT sandall.us PGP: 0xA8EFDD61 | http://www.sourcemage.org/
http://eric.sandall.us/ | http://counter.li.org/ #196285

Attachment: signature.asc
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page