Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Ladislav Hagara (90fc79f43ea599742417fde42a08936c6c5c6f28)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Ladislav Hagara <ladislav.hagara AT unob.cz>
  • Cc: "sm-commit AT lists.ibiblio.org" <sm-commit AT lists.ibiblio.org>
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Ladislav Hagara (90fc79f43ea599742417fde42a08936c6c5c6f28)
  • Date: Tue, 11 Mar 2008 22:52:59 +0100


seems "gaze version lm_sensors" does't work for normal user with
devel sorcery stable and test sorcery are OK
could you verify it?
You're right, with devel sorcery and normal user it just hangs without
doing anything.
It works if you do it as root. The problem is that the DETAILS uses
persistent_save, which needs root privileges ...

This can be fixed in multiple ways:
- fix the choice already in PREPARE
- only run persistent_save if root
- remove DEFAULT and don't change the user's choice (the query can tell which
branch is the default)
- ...

To me it doesn't seem right that there's a function call like that in
DETAILS. I think it belongs in PREPARE, if it's needed at all.

I really do not know why this function is in DETAILS.
It was added by Mathieu Lonjaret:
git show f27f81ec0eacf4675f6775bb6261c3d9f94864fd

+2008-01-12 Mathieu Lonjaret <lejatorn AT sourcemage.org>
+ * fixed non persistence of branch change in DETAILS (credits go to
+ ryuji and lynxlynxlynx).


I think, it works for me without it. User just choose for example DEFAULT in PREPARE and it is saved in /etc/sorcery/local/depends/lm_sensors.p.
I use the same approach it gnutls and nobody argued.
What is the problem with branches?

--
Ladislav Hagara




Archive powered by MHonArc 2.6.24.

Top of Page