Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master games grimoire by Dale E. Edmons (855a953c6cbd5c3d360b0d6a9995d9230d3a849f)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Jaka Kranjc <lynx AT mages.ath.cx>
  • To: demaillists AT comcast.net
  • Cc: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master games grimoire by Dale E. Edmons (855a953c6cbd5c3d360b0d6a9995d9230d3a849f)
  • Date: Mon, 25 Feb 2008 18:26:45 +0100

On Monday 25 of February 2008 18:18:25 you wrote:
> Jaka Kranjc wrote:
> > On Monday 25 of February 2008 16:11:51 Dale E. Edmons wrote:
> >> --- /dev/null
> >> +++ b/games-arcade-3d/supertuxkart/BUILD
> >> @@ -0,0 +1,8 @@
> >> +./configure \
> >> + --prefix=${INSTALL_ROOT}/usr/games \
> >> + --datadir=${INSTALL_ROOT}/usr/share \
> >> + --sysconfdir=${INSTALL_ROOT}/etc \
> >> + --localstatedir=${INSTALL_ROOT}/var/games \
> >> + --mandir=${INSTALL_ROOT}/usr/share/man \
> >> + --infodir=${INSTALL_ROOT}/usr/share/info $OPTS &&
> >> +make
> >
> > Does default_games_build not cut it?
>
> Not so far. Even with $OPTS. I sent a bug to upstream. They
> have some of datadir's confused with prefix and bindir's. See
> the INSTALL.
You have a custom INSTALL already, so why complicate the matter further?

> >> +SOURCE_DIRECTORY="${BUILD_DIRECTORY}/${SPELL}-0.3"
> >
> > It would be nice to derive the 0.3 from the VERSION, so this field won't
> > need to be updated on subsequent version bumps.
> >
> >> +++ b/games-arcade-3d/supertuxkart/INSTALL
> >> @@ -0,0 +1,13 @@
> >> +make install &&
> >> +
> >> +# Fix broken Makefile. bug #1901428
> >> +GAMEDIR="$INSTALL_ROOT/usr/games" &&
> >> +SHAREDIR="$INSTALL_ROOT/usr/share" &&
> >> +mv $GAMEDIR/bin/$SPELL $GAMEDIR/$SPELL &&
> >> +mv $GAMEDIR/share/applications/$SPELL.desktop
> >> $SHAREDIR/share/applicatons/$SPELL.desktop &&
> >
> > share/share?
> >
> >> +mv
> >> $GAMEDIR/share/pixmaps/${SPELL}* $SHAREDIR/share/pixmaps/$SPELL.desktop
> >> && +
> >> +# These might fail if there's other stuff there.
> >> +rmdir $INSTALL_ROOT/usr/games/share/applications || true &&
> >> +rmdir $INSTALL_ROOT/usr/games/share/pixmaps || true &&
> >> +rmdir $INSTALL_ROOT/usr/games/{bin,share} || true
> >
> > This is bad. Now anything else in this file could fail and the spell
> > would say INSTALL was succesful.
>
> I can remove the true. This whole file may go away if upstream
> fixes the bug.
Do it. I don't think the spell casts at the moment at all, but that is due to
the previous chunk.

--
We cannot command nature except by obeying her. --Sir Francis Bacon
Have a sourcerous day! www.sourcemage.org

Attachment: signature.asc
Description: This is a digitally signed message part.




Archive powered by MHonArc 2.6.24.

Top of Page