sm-commit AT lists.ibiblio.org
Subject: Source Mage code commit list
List archive
Re: [SM-Commit] GIT changes to master games grimoire by Dale E. Edmons (4e9ab758ae7d516d7d63c37c8088ef6f797e5798)
- From: Jaka Kranjc <lynx AT mages.ath.cx>
- To: sm-commit AT lists.ibiblio.org
- Subject: Re: [SM-Commit] GIT changes to master games grimoire by Dale E. Edmons (4e9ab758ae7d516d7d63c37c8088ef6f797e5798)
- Date: Sun, 10 Feb 2008 10:40:13 +0100
On Sunday 10 of February 2008 09:21:20 Dale E. Edmons wrote:
> +++ b/games-arcade-2d/atris/DEPENDS
> @@ -0,0 +1,2 @@
> +depends sdl_ttf &&
> +depends ttf-bitstream-vera
Does it really need this font? I bet it can also work nicely with dejavu,
since it is a derivative work. And judging from the patch later on, is this
needed at all? It looked like a font is already provided and it is not vera.
> + SHORT="*tris clone"
> +cat << EOF
> +Another *tris clone.
> +EOF
Please add a longer description. This "field" is not called a long
description
by chance. And one is immediately available on their site,
> --- /dev/null
> +++ b/games-arcade-2d/atris/HISTORY
> @@ -0,0 +1,7 @@
> +2007-12-07 linuxfan <demaillists AT comcast.net>
> + * PRE_BUILD: wrote patch to make atis SMGL compliant
> +2007-12-07 linuxfan <demaillists AT comcast.net>
> + * BUILD, DEPENDS, DETAILS, INSTALL: Package not well-behaved.
> +2007-12-07 linuxfan <demaillists AT comcast.net>
> + * BUILD, DEPENDS, DETAILS, , INSTALL: spell created
> +
Newlines? Don't be so hasty.
http://wiki.sourcemage.org/HISTORY
> --- /dev/null
> +++ b/games-arcade-2d/atris/PRE_BUILD
> @@ -0,0 +1,5 @@
> +default_pre_build &&
> +cd /usr/src &&
Not only is this step not needed, but don't ever use absolute paths in
spells!
Only a few rare cases warrant it.
--
We cannot command nature except by obeying her. --Sir Francis Bacon
Have a sourcerous day! www.sourcemage.org
Attachment:
signature.asc
Description: This is a digitally signed message part.
-
[SM-Commit] GIT changes to master games grimoire by Dale E. Edmons (4e9ab758ae7d516d7d63c37c8088ef6f797e5798),
Dale E. Edmons, 02/10/2008
- Re: [SM-Commit] GIT changes to master games grimoire by Dale E. Edmons (4e9ab758ae7d516d7d63c37c8088ef6f797e5798), Jaka Kranjc, 02/10/2008
Archive powered by MHonArc 2.6.24.