Source Mage code commit list

[flux <flux AT sourcemage.org>]

Jaka Kranjc (lynx AT mages.ath.cx) wrote [07.11.27 18:33]:
> Great to more cauldron work being done again. :) I know you just started, 
> but 
> here are the problems I noticed:

Thanks for helping to point out errors! You must not be busy enough with
sorcery these days ;-P hehehe (j/k!).
> 
> > +cauldron_enter_chroot() {
> > +   mount --bind ${HOST}/dev ${CAULDRON_BUILD}/dev
> > +   mount --bind ${HOST}/dev/pts ${CAULDRON_BUILD}/dev/pts
> > +   mount --bind ${HOST}/proc ${CAULDRON_BUILD}/proc
> > +}
> > +
> > +cauldron_exit_chroot() {
> > +   umount ${CAULDRON_BUILD}/dev
> > +   umount ${CAULDRON_BUILD}/dev/pts
> Looks like a copy/paste mistake to me - afaik /dev/pts needs to be 
> unmounted 
> first for this to work.
> 

Yes, definitely a mistake. Should be dev/pts first followed by dev.

> > +cauldron_create_base_toolchain() {
> > +   for spell in ${HOST_TOOLCHAIN}
> > +   do
> > +           if [[ -f
> > ${HOST_SORCERY_SPOOL}/${spell}-*-${HOST_ARCH}-${HOST_SYSTEM}-linux-gnu.tar.
> >bz2 ]] +             then
> > +                   cp
> > ${HOST_SORCERY_SPOOL}/${spell}-*-${HOST_ARCH}-${HOST_SYSTEM}-linux-gnu.tar.
> >bz2 +                else
> cp where?

Yep. I added the dir to cp too. Will be in the next commit. I also fixed
the following tar command to match with the cp command (use of
${HOST_ARCH} was not uniform across them).

> 
> > +   # copy the host's resolv.conf in order to dl packages from net
> > +   cp /etc/resolv.conf ${CAULDRON_BUILD}/
> Sometimes this file is a symlink, I think in the case of rp-pppoe, so it 
> would 
> be good to check for that first and follow the link if it is one. Low 
> priority.
> 

Thanks for pointing this out. I've never run pppoe so I was unaware of
this. I'll add in some sanity checking :)

> > +cauldron_install_copy_kernel() {
> > +   cp ${ISO}/boot/linux ${TARGET_SYSTEM};
> > +   cp --parents -r ${ISO}/lib/modules/${LINUX_VER}/* ${TARGET_SYSTEM};
> > +   cauldron_enter_chroot(${TARGET_SYSTEM});
> bash: syntax error near unexpected token `('

A lot of the errors so far are mostly due to the fact that I am in the
prototyping stage, and was mostly transferring from pseudo-code (hence
the use of parentheses here). I have fixed this, and will be in the next
commit.

Thanks for helping out with bug-squashing before I was even ready to
hunt! :-D

-- 
Justin "flux" Boffemmyer
Cauldron wizard and general mage
Source Mage GNU/Linux
http://www.sourcemage.org

Attachment: pgpS3f7Ua9ACA.pgp
Description: PGP signature