Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Ismael E. Luceno (30cc9c7f28064589976712c995c5cbb8a653ed18)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Jaka Kranjc <lynx AT mages.ath.cx>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Ismael E. Luceno (30cc9c7f28064589976712c995c5cbb8a653ed18)
  • Date: Thu, 29 Nov 2007 10:22:38 +0100

On Thursday 29 of November 2007 05:59:21 Ismael E. Luceno wrote:
> GIT changes to master grimoire by Ismael E. Luceno
> <ismael.luceno AT gmail.com>:
>
> smgl/initng-ifiles/BUILD | 6 ++++++
> smgl/initng-ifiles/DEPENDS | 1 +
> smgl/initng-ifiles/DETAILS | 38
> ++++++++++++++++++++++++++++++++++++++ smgl/initng-ifiles/HISTORY | 5
> +++++
> smgl/initng-ifiles/PREPARE | 5 +++++
> smgl/initng-ifiles/initng.gpg |binary
> smgl/initng/BUILD | 6 ++++++
> smgl/initng/DEPENDS | 4 ++++
> smgl/initng/DETAILS | 22 ++++++++++++++++++++++
> smgl/initng/HISTORY | 5 +++++
> smgl/initng/initng.gpg |binary
> 11 files changed, 92 insertions(+)
Since both spells likely use the same initng.gpg, it would be best to move it
one level up in the hierarchy, so it can be shared. Sorcery will find it
automatically, it searches not only in the spell dir, but also in the section
and grimoire one.

And since they are new spells, a ChangeLog entry is missing.

> +++ b/smgl/initng-ifiles/BUILD
> @@ -0,0 +1,6 @@
> +CFLAGS="${CFLAGS/-Os/-O2}" &&
> +cd ${SOURCE_DIRECTORY} &&
> +mkdir build &&
> +cd build &&
> +cmake .. &&
> +make_single
make_single is used to ensure make will be run with a single makejob. BUT it
does not run make itself! So if you want this functionality, append a call to
make and make_normal (to reset this functionality).

The same applies to the initng BUILD.

> +++ b/smgl/initng/DETAILS
> @@ -0,0 +1,22 @@
> + SPELL=initng
> + VERSION=0.6.10.2
> + SOURCE=${SPELL}-${VERSION}.tar.bz2
> + SOURCE2=${SOURCE}.sig
> + SOURCE_URL[0]=http://download.initng.org/${SPELL}/v0.6/${SOURCE}
Both DETAILS could be improved by getting that 0.6 in the SOURCE_URL from
VERSION:
SOURCE_URL[0]=http://download.initng.org/${SPELL}/v${VERSION:0:3}/${SOURCE}

This way it won't need to be changed once 0.7 and later are released,
provided
you keep the same schema on the download site.

--
We cannot command nature except by obeying her. --Sir Francis Bacon
Have a sourcerous day! www.sourcemage.org

Attachment: signature.asc
Description: This is a digitally signed message part.




Archive powered by MHonArc 2.6.24.

Top of Page