Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Treeve Jelbert (7e799545e2367f8dbf46db5c458036e5a1a2ce40)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Jaka Kranjc <lynx AT mages.ath.cx>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Treeve Jelbert (7e799545e2367f8dbf46db5c458036e5a1a2ce40)
  • Date: Wed, 7 Nov 2007 14:16:06 +0000

On Wednesday 07 of November 2007 13:08:50 Treeve Jelbert wrote:
> --- a/kde4/KDE_DEPENDS
> +++ b/kde4/KDE_DEPENDS
> @@ -37,7 +37,8 @@ case $SPELL in
> ;;
>
> kdebase-workspace4)
> - depends kdelibs4 &&
> + sub_depends qt4 OPENGL &&
> + depends kdebase4-runtime &&
> depends X11-SERVER
> ;;
Are you sure kdelibs4 isn't needed for this? Looks suspicious to me. Also now
the added subdependency is potentially dangerous. From the docs:
"IMPORTANT: never call sub_depends without first explicitly depending on the
providing spell."


> --- a/x11-toolkits/qt4/PRE_SUB_DEPENDS
> +++ b/x11-toolkits/qt4/PRE_SUB_DEPENDS
> @@ -1,6 +1,7 @@
> case $THIS_SUB_DEPENDS in
> DBUS) is_depends_enabled $SPELL dbus && return 0;;
> # GIF) is_depends_enabled $SPELL LIBGIF && return 0;;
> + OPENGL) is_depends_enabled $SPELL OPENGL && return 0;;
This won' work.
Example, my kdelibs install has gamin installed as a provider of FAM:
navaden@lynxlynx kde-m17n $ is_depends_enabled kdelibs FAM; echo $?
1
navaden@lynxlynx kde-m17n $ SPELL=kdelibs; is_depends_enabled $SPELL
$(get_spell_provider $SPELL FAM); echo $?
0

Try with something like the second one. I've added an example to the docs.

--
We cannot command nature except by obeying her. --Sir Francis Bacon
Have a sourcerous day! www.sourcemage.org

Attachment: signature.asc
Description: This is a digitally signed message part.




Archive powered by MHonArc 2.6.24.

Top of Page