Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Vlad Glagolev (52d0e562efa6cd0e3628e04d9dc7c1b9a8480839)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Jaka Kranjc <lynx AT mages.ath.cx>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Vlad Glagolev (52d0e562efa6cd0e3628e04d9dc7c1b9a8480839)
  • Date: Mon, 5 Nov 2007 10:06:13 +0000

On Monday 05 of November 2007 00:35:53 Vlad Glagolev wrote:
> GIT changes to master grimoire by Vlad Glagolev <codex AT sourcemage.org>:
>
> disk/tkdvd/BUILD | 1 +
> disk/tkdvd/DEPENDS | 3 +++
> disk/tkdvd/DETAILS | 26 ++++++++++++++++++++++++++
> disk/tkdvd/HISTORY | 2 ++
> disk/tkdvd/INSTALL | 3 +++
> 5 files changed, 35 insertions(+)
>
> New commits:
> commit c5fe08882423806f72146936ab2df502e8d2a9dc
> Author: Vlad Glagolev <codex AT sourcemage.org>
> Commit: Vlad Glagolev <codex AT sourcemage.org>
>
> tkdvd: GUI for dvd+rw-tools written in TCL/Tk. added (4.0.7).
First, you forgot to add the Changelog entry like with the previous commits.

> diff --git a/disk/tkdvd/BUILD b/disk/tkdvd/BUILD
> new file mode 100755
> index 0000000..1a72529
> --- /dev/null
> +++ b/disk/tkdvd/BUILD
> @@ -0,0 +1 @@
> +./configure --prefix=/usr/bin
Is this really enough? You can see everything default_build passes with:
declare -f default_build # or climbing through the code
The most common symptom of such code is that the man and info pages are
misinstalled. --prefix=/usr/bin is also unusual (the bin part) and lacks
$INSTALL_ROOT infront of it.

> diff --git a/disk/tkdvd/INSTALL b/disk/tkdvd/INSTALL
> new file mode 100755
> index 0000000..902f103
> --- /dev/null
> +++ b/disk/tkdvd/INSTALL
> @@ -0,0 +1,3 @@
> +./install.tcl &&
> +install -m 755 tkdvd-install.sh /usr/bin/tkdvd &&
> +install -m 644 icons/*.png /usr/share/pixmaps
The target paths lack $INSTALL_ROOT
You can get familiar with it by reading this archived mail:
Re: [SM-Commit] GIT changes to master grimoire by Thomas Orgis
(c0695802d6900775e09054cef09412bdd1fd8647)

--
We cannot command nature except by obeying her. --Sir Francis Bacon
Have a sourcerous day! www.sourcemage.org

Attachment: signature.asc
Description: This is a digitally signed message part.




Archive powered by MHonArc 2.6.24.

Top of Page