Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Thomas Orgis (e29981cde83e143459e19efbdce706851a8b0cbe)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Thomas Orgis <thomas-forum AT orgis.org>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Thomas Orgis (e29981cde83e143459e19efbdce706851a8b0cbe)
  • Date: Mon, 26 Mar 2007 23:46:02 +0200

Am Mon, 26 Mar 2007 15:58:44 -0500
schrieb Jeremy Blosser <jblosser-smgl AT firinn.org>:

> On Mar 18, Thomas Orgis [scm AT mail.sourcemage.org] wrote:
> > Perhaps we think of something better when reworking the accounts
> > stuff and smgl-fhs can be reduced
> > to only creating dirs.
>
> This is still bug 9788.

Indeed. This long standing one will be resolved once we got account management
straight, with help of castfs hopefully.

> > +# That is ugly, but we need to ensure minimal accounts that usually are
> copied
> > +# from iso. At least in theory (for chroots), we should create
> everything via spells.
> > +# Root account is always needed, bin user/group is provided by iso and
> an unknown
> > +# number of spells need it. Perhaps one should make a
> smgl-system-accounts spell and
> > +# remove all create_(account|group) from here?
>
> Thomas can you *please* fix your editor so that at least when you work on
> SMGL things it uses a proper 80 column break? It's bad enough when mails
> and commit messages are wrapping, but I really don't like to see comments
> and spell code overly wide and wrapping, it makes it hard for others to
> manage.

Oh, the legacy of the punch cards!

I agree that there is one too long line in INSTALL:

# number of spells need it. Perhaps one should make a smgl-system-accounts
spell and

That's 84 chars. Sorry, that one slipped through. I made sure the others are
<=80
and they indeed are. Same in HISTORY. Still, your mail reply greatly messed up
with the quoting when breaking the lines but only putting one ">" in there.
Not breaking lines would not have broken the quoting... anyhow:
You would rather like them <=72? Or is it more about the git comment, which
indeed is wider?
Does the 80char rule also apply for the commit comment? I guess so, since it
goes
out to a mailing list (with a stupid...
Well, I'll wrap that, too in future. But for sure I won't "fix" my editor to
do that
automatically, since that can _break_ badly (not just the lines;-) when
programming
(even bash).

Please don't be offensed when I express my disliking for the 80char issue,
I will obey the rules as good as I can, but I won't tell you I'm glad being
forced into the punch card legacy;-)
So please, just make it clear: Lines up to 80 characters in spell files _and_
git
comments (I hope exceptions in spell files are allowed where breaking a long
command line would only complicate things or is not easily possible)?


Alrighty then,

Thomas.




Archive powered by MHonArc 2.6.24.

Top of Page