Source Mage code commit list

[Pol Vinogradov <vin.public AT gmail.com>]

On Wed, 28 Feb 2007 09:03:43 +0100
Thomas Orgis <thomas-forum AT orgis.org> wrote:

> Am Tue, 27 Feb 2007 14:20:11 -0600
> schrieb Pol Vinogradov <scm AT mail.sourcemage.org>:
>
> >  # Clean out the old alsa drivers. FIXME: Bad location for 2.6!
> > -rm  -f  /lib/modules/`installed_version linux`/misc/snd*  &&
> > +rm  -f  ${TRACK_ROOT}/lib/modules/`get_kernel_version`/misc/snd*
> > &&
>
> You sure you mean TRACK_ROOT, not INSTALL_ROOT? And does the spell
> really need to remove the old modules in BUILD (I don't use it, just
> asking...)?
my simple thought was that there're no modules under INSTALL_ROOT at
this stage
> >
> > -if [ -e /proc/config.gz ] ; then
> > -    if [ `zgrep -c CONFIG_SOUND=m /proc/config.gz` = 1 ] ; then
> > +if [ -e ${TRACK_ROOT}/proc/config.gz ] ; then
>
> Hm, somehow I feel that /proc is /proc . I's nothing that is
> installed...
/etc/fstab may vary...
> > +elif [ `grep -c CONFIG_SOUND=m
> > ${TRACK_ROOT}/etc/sorcery/local/kernel.config`
> > = 1 ] ; then modprobe -q soundcore
>
> What about get_sorcery_kernel_config / get_running_kernel_config?
i'll have a look at it...
> And here ... I'm even more wary about TRACK_ROOT ... sorcery has it's
> config always in /etc (imho), when casting with
> INSTALL_ROOT/TRACK_ROOT, the kernel.config will always be
> in /etc/sorcery/... unless you copied it manually somewhere. Am I
> wrong here?
all these directories may be customized in sorcery config file imho,
btw i've no /etc/sorcery/local/kernel.config in my system (devel
sorcery though). i agree these *_ROOTs suck enough but i want a clear
documentation with explanation which ROOT should be used in various
cases. wiki page is too difficult to understand (for me) and imho isn't
up to date.
> > --- a/audio-drivers/alsa-driver/CONFIGURE
> > +++ b/audio-drivers/alsa-driver/CONFIGURE
>
> > +  rm  -f  ${TRACK_ROOT}/etc/modules.d/alsa  &&
> > +  cp  ${TRACK_ROOT}/etc/modules.conf
> > ${TRACK_ROOT}/tmp/modules.conf  &&
> > +  grep  -v  "alsa"   <  ${TRACK_ROOT}/tmp/modules.conf  >
> > ${TRACK_ROOT}/etc/modules.conf  &&
>
> Again this spell deletes stuff, even in CONFIGURE (you didn't
> introduce it but now I see these lines...) - is that necessary?
> Perhaps a comment above these lines would be good if it is the case.
> And still, I think it should be INSTALL_ROOT.
>
> > +[ -e ${TRACK_ROOT}/etc/sysconfig/alsa ] && sedit "s:\$CARD:
> > $CARD:"  ${TRACK_ROOT}/etc/sysconfig/alsa
>
> ...
>
> > --- a/audio-drivers/alsa-driver/INSTALL
> > +++ b/audio-drivers/alsa-driver/INSTALL
> > +    echo  "alias snd-card-`expr $i - 1` $C">>
> > ${INSTALL_ROOT}/etc/modules.d/alsa &&
> > +    echo  "alias snd-slot-`expr $i - 1` snd-card-`expr $i - 1`">>
> > ${INSTALL_ROOT}/etc/modules.d/alsa +if  [  -f
> > ${TRACK_ROOT}/dev/snd  ];  then
> > +  rm  -f   ${TRACK_ROOT}/dev/snd
> > [...]
>
> Now you used both TRACK_ROOT and INSTALL_ROOT for file locations --
> why? We had this INSTALL_ROOT debate here some time ago and now I'm
> again starting to wonder if I got it right. I thought that you use
> INSTALL_ROOT in the spell for location of files and TRACK_ROOT for
> contents (some config/script that needs a runtime location). Please
> correct me if there is some other reasoning going on.
right, and i use TRACK_ROOT for removing existing files which then will
be installed under INSTALL_ROOT. simple logic i think :)
>
> Thomas.

--
Sincerely yours Pol Vinogradov
E-mails: public AT sourcemage.org; vin.public AT gmail.com;
pol-vinogradov AT mail.ru
Jabber ID: vinpol AT jabber.ru
Registered as #384571 at Linux Counter (http://counter.li.org/)

Attachment: pgpYhCptkITDB.pgp
Description: PGP signature