Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Jeremy Blosser (ecc1547d4dcc9fb9052d4ddd07e6999cf0989bd5)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Jeremy Blosser <jblosser-smgl AT firinn.org>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Jeremy Blosser (ecc1547d4dcc9fb9052d4ddd07e6999cf0989bd5)
  • Date: Thu, 18 Jan 2007 20:55:11 -0600

On Jan 18, Jeremy Blosser [scm AT mail.sourcemage.org] wrote:
> GIT changes to master grimoire by Jeremy Blosser <jblosser-smgl AT firinn.org>:
>
> smgl/init.d/HISTORY | 4 ----
> smgl/init.d/init.d/mountall.sh | 6 +-----
> 2 files changed, 1 insertion(+), 9 deletions(-)
>
> New commits:
> commit ecc1547d4dcc9fb9052d4ddd07e6999cf0989bd5
> Author: Jeremy Blosser <jblosser-smgl AT firinn.org>
> Commit: Jeremy Blosser <jblosser-smgl AT firinn.org>
>
> Revert "init.d: fix #7311, proc not showing in /etc/mtab"
>
> This reverts commit 95f13eb1ac5a9dc00b73497abf8ed6c792b0d0c7.

I noted it in the bug but the main reason for this is that there's a grep
in there, before the fses are mounted. If /usr isn't in the rootfs this
will fail. I didn't test if it takes the boot down or not but it probably
would.

Also it's bad to assume /proc is mounted like this; /proc is still a
non-mandatory kernel feature.

> diff --git a/smgl/init.d/HISTORY b/smgl/init.d/HISTORY
> index 815ab08..f5e43f8 100644
> --- a/smgl/init.d/HISTORY
> +++ b/smgl/init.d/HISTORY
> @@ -29,10 +29,6 @@
> 2006-10-26 Jaka Kranjc <lynxlynxlynx AT sourcemage.org>
> * INSTALL: use TRACK_ROOT when linking #9163
>
> -2006-10-15 Jaka Kranjc <lynxlynxlynx AT sourcemage.org>
> - * init.d/devices: fix #7311, proc not showing in /etc/mtab
> - * DETAILS: PATCHLEVEL++
> -
> 2006-09-23 Flavien Bridault <vlaaad AT sourcemage.org>
> * DEPENDS: Check which udev spell we should cast according to the
> kernel version
> diff --git a/smgl/init.d/init.d/mountall.sh b/smgl/init.d/init.d/mountall.sh
> index d896e90..89b7b84 100755
> --- a/smgl/init.d/init.d/mountall.sh
> +++ b/smgl/init.d/init.d/mountall.sh
> @@ -58,11 +58,7 @@ start()
>
> echo "Mounting proc file system..."
> mount -a -t /proc
> - evaluate_retval &&
> -# bug 7311
> - if ! grep -wq "/proc" /etc/mtab; then
> - builtin echo 'none /proc proc rw 0 0' >> /etc/mtab
> - fi
> + evaluate_retval
>
> # find devices that were set up in initramfs/rd
> if optional_executable /sbin/dmsetup

Attachment: pgpXwTDYLptba.pgp
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page