Skip to Content.
Sympa Menu

sm-commit - [SM-Commit] GIT changes to master grimoire by Juuso Alasuutari (8f7d8a9a1f25c81bfb1dfe436e6067ca6c7c34ac)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Juuso Alasuutari <scm AT mail.sourcemage.org>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: [SM-Commit] GIT changes to master grimoire by Juuso Alasuutari (8f7d8a9a1f25c81bfb1dfe436e6067ca6c7c34ac)
  • Date: Sat, 23 Dec 2006 15:45:21 -0600

GIT changes to master grimoire by Juuso Alasuutari <iuso AT sourcemage.org>:

kde-apps/kid3/DEPENDS | 23 +++++++++++------------
kde-apps/kid3/HISTORY | 5 +++++
2 files changed, 16 insertions(+), 12 deletions(-)

New commits:
commit 8f7d8a9a1f25c81bfb1dfe436e6067ca6c7c34ac
Author: Juuso Alasuutari <iuso AT sourcemage.org>
Commit: Juuso Alasuutari <iuso AT sourcemage.org>

kid3: some dependency fixing

diff --git a/kde-apps/kid3/DEPENDS b/kde-apps/kid3/DEPENDS
index d8804ed..4454d8c 100755
--- a/kde-apps/kid3/DEPENDS
+++ b/kde-apps/kid3/DEPENDS
@@ -1,17 +1,13 @@
-depends g++ &&
-
-# This is optional really, but because compile fails if at least one out
-# of id3lib, taglib, and libvorbis isn't selected, we'll force this in.
-depends id3lib &&
+depends g++ &&

if [[ $KID3_KDE == "--with-kde" ]]
then
. "$SECTION_DIRECTORY/KDE_DEPENDS"
else
- . "$GRIMOIRE/FUNCTIONS" &&
depends X11-LIBS &&
depends qt-x11 &&
depends libpng &&
+ . "$GRIMOIRE/FUNCTIONS" &&
if check_if_xorg_modular_libs
then
depends libxext &&
@@ -21,10 +17,15 @@ else
fi
fi &&

-optional_depends taglib \
- "--with-taglib" \
- "--without-taglib" \
- "to use TagLib" &&
+# Taglib, id3lib, and libvorbis are optional but build fails if none
+# of them are selected. The author recommended taglib as the minimum
+# in a mail he sent me. -iuso
+depends taglib &&
+
+optional_depends id3lib \
+ "--with-id3lib" \
+ "--without-id3lib" \
+ "to use id3lib" &&

message "${MESSAGE_COLOR}libvorbis is required for FLAC and" \
"MusicBrainz support.${DEFAULT_COLOR}" &&
@@ -36,8 +37,6 @@ optional_depends libvorbis
--without-musicbrainz" \
"to use Ogg Vorbis" &&

-# Please check if this limitation (upstream bug) still applies after
-# version bumps (this hack applied for 0.8.1)
. "$GRIMOIRE/is_depends_enabled.function" &&
if is_depends_enabled $SPELL libvorbis
then
diff --git a/kde-apps/kid3/HISTORY b/kde-apps/kid3/HISTORY
index 9645ef2..a2e11d8 100644
--- a/kde-apps/kid3/HISTORY
+++ b/kde-apps/kid3/HISTORY
@@ -1,3 +1,8 @@
+2006-12-23 Juuso Alasuutari <iuso AT sourcemage.org>
+ * DEPENDS: Made taglib dependency non-optional and id3lib
+ optional (program author's recommendation), did some
+ reformatting.
+
2006-12-16 Juuso Alasuutari <iuso AT sourcemage.org>
* DETAILS: Version 0.8.1, updated long description, gpg->sha512.
* CONFIGURE: Added, query about KDE support.



  • [SM-Commit] GIT changes to master grimoire by Juuso Alasuutari (8f7d8a9a1f25c81bfb1dfe436e6067ca6c7c34ac), Juuso Alasuutari, 12/23/2006

Archive powered by MHonArc 2.6.24.

Top of Page