Skip to Content.
Sympa Menu

sm-commit - Re: [SM-Commit] GIT changes to master grimoire by Bearcat Sandor (5bc5116ac37bd1bb955e0e75c5090065b2680cea)

sm-commit AT lists.ibiblio.org

Subject: Source Mage code commit list

List archive

Chronological Thread  
  • From: Jeremy Blosser <jblosser-smgl AT firinn.org>
  • To: sm-commit AT lists.ibiblio.org
  • Subject: Re: [SM-Commit] GIT changes to master grimoire by Bearcat Sandor (5bc5116ac37bd1bb955e0e75c5090065b2680cea)
  • Date: Tue, 10 Oct 2006 17:56:45 -0500

On Aug 19, Bearcat Sandor [scm AT mail.sourcemage.org] wrote:
> GIT changes to master grimoire by Bearcat Sandor
> <sourcemage AT feline-soul.com>:
>
> chat-im/jabberd/init.d/jabberd | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> New commits:
> commit 5bc5116ac37bd1bb955e0e75c5090065b2680cea
> Author: Bearcat Sandor <sourcemage AT feline-soul.com>
> Commit: Bearcat Sandor <sourcemage AT feline-soul.com>
>
> altered jabberd init script to run as root. It will not start otherwise.

This is a bad idea... this is a network-listening daemon running as root.
Why does it need this? I know it hasn't always, I run it as jabber fine.
This is a major change, there should at least have been a bug discussion on
this.

> diff --git a/chat-im/jabberd/init.d/jabberd b/chat-im/jabberd/init.d/jabberd
> index b899dba..e1d30ad 100755
> --- a/chat-im/jabberd/init.d/jabberd
> +++ b/chat-im/jabberd/init.d/jabberd
> @@ -7,21 +7,21 @@ NEEDS="+network +remote_fs"
>
> case $1 in
> start) echo "Starting jabberd..."
> - daemon -u jabber -n jabberd jabberd
> + daemon -u root -n jabberd jabberd
> evaluate_retval
> ;;
>
> stop) echo "Stopping jabberd..."
> - daemon -u jabber -n jabberd --stop
> + daemon -u root -n jabberd --stop
> evaluate_retval
> ;;
>
> restart) echo "Restarting jabberd..."
> - daemon -u jabber -n jabberd --restart
> + daemon -u root -n jabberd --restart
> evaluate_retval
> ;;
>
> - status) daemon -v -u jabber -n jabberd --running
> + status) daemon -v -u root -n jabberd --running
> ;;
>
> *) echo "Usage: $0 {start|stop|restart|status}"

Attachment: pgpAEjbvzUBXn.pgp
Description: PGP signature




Archive powered by MHonArc 2.6.24.

Top of Page